From: Pavel Roskin <proski@gnu.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Christoph Hellwig <hch@lst.de>,
jgarzik@pobox.com, hermes@gibson.dropbear.id.au,
netdev@oss.sgi.com
Subject: Re: [PATCH 11/12] orinoco: monitor mode support
Date: Tue, 17 May 2005 15:43:14 -0400 [thread overview]
Message-ID: <1116358994.5534.2.camel@dv.roinet.com> (raw)
In-Reply-To: <20050514173947.GA32235@electric-eye.fr.zoreil.com>
On Sat, 2005-05-14 at 19:39 +0200, Francois Romieu wrote:
> > + drop:
> > + stats->rx_errors++;
> > + stats->rx_dropped++;
> > +}
>
> -> leak (skb).
Indeed. Thank you! Please apply this on top of the original patches:
Signed-off-by: Pavel Roskin <proski@gnu.org>
--- orinoco.c
+++ orinoco.c
@@ -1180,7 +1180,7 @@ static void orinoco_rx_monitor(struct ne
u16 fc;
int err;
int len;
- struct sk_buff *skb;
+ struct sk_buff *skb = NULL;
struct orinoco_private *priv = netdev_priv(dev);
struct net_device_stats *stats = &priv->stats;
hermes_t *hw = &priv->hw;
@@ -1268,6 +1268,8 @@ static void orinoco_rx_monitor(struct ne
drop:
stats->rx_errors++;
stats->rx_dropped++;
+ if (skb)
+ dev_kfree_skb_irq(skb);
}
static void __orinoco_ev_rx(struct net_device *dev, hermes_t *hw)
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2005-05-17 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-14 15:31 [PATCH 11/12] orinoco: monitor mode support Christoph Hellwig
2005-05-14 17:39 ` Francois Romieu
2005-05-17 19:43 ` Pavel Roskin [this message]
2005-05-17 21:22 ` Francois Romieu
2005-05-23 3:40 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116358994.5534.2.camel@dv.roinet.com \
--to=proski@gnu.org \
--cc=hch@lst.de \
--cc=hermes@gibson.dropbear.id.au \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.