RE: [PATCH] reiserfs module for pygrub

[Jeremy Katz <katzj@redhat.com>]

On Tue, 2005-05-24 at 01:14 +0100, Ian Pratt wrote:
>  > What if we check instead for the headers being present and 
> > only building the filesystem modules that there's support for 
> > on the system?  Then distributors can ensure they have the 
> > right things in their buildsystem and anyone else can do the 
> > same.  The attached patch should implement that for libext2fs.
> 
> Seems a sensible approach to me. Some people will no doubt hate the fact
> that the output will depend on the build host. Perhaps have an
> environment variable that can be set to overide the autodetect? (and
> hence cause a build failure)

I guess it's easy enough to do something like this.  I wish distutils
had a standardized way of doing things like this similar to autoconf
(... and this even with how much I hate autoconf ;-)
 
> > > Also, at runtime, are there
> > > issues with libraries being present? Can you load the library 
> > > dynamically if required?
> > 
> > The libraries get linked dynamically into the python module.  
> > If at runtime, the library isn't present, it won't cause a 
> > fatal error (you won't be able to access those types of 
> > filesystems, but it won't fall over on the import)
> 
> Given that the libext2fs is 90KB, I wander if we should just staticaly
> link? Not sure.

I'm not sure there's a way to do static linking in distutils without
completely reinventing the wheel.  When you start thinking about lib vs
lib64 differences, this is less than fun.

Jeremy