From: Alexander Nyberg <alexn@telia.com>
To: Andrew Morton <akpm@osdl.org>
Cc: vgoyal@in.ibm.com, linux-kernel@vger.kernel.org, fastboot@lists.osdl.org
Subject: Re: [Fastboot] [1/2] kdump: Use real pt_regs from exception
Date: Wed, 25 May 2005 14:14:56 +0200 [thread overview]
Message-ID: <1117023296.877.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20050525020749.1ad56a80.akpm@osdl.org>
ons 2005-05-25 klockan 02:07 -0700 skrev Andrew Morton:
> Alexander Nyberg <alexn@telia.com> wrote:
> >
> > -extern void machine_crash_shutdown(void);
> > +extern void machine_crash_shutdown(struct pt_regs *);
>
> That'll break x86_64, ppc, ppc64 and s/390.
I'm such an idiot.
Make sure all arches take pt_regs * as argument to
machine_crash_shutdown(). (now cross-compiled on above arches except
s/390).
Signed-off-by: Alexander Nyberg <alexn@telia.com>
Index: mm/arch/ppc/kernel/machine_kexec.c
===================================================================
--- mm.orig/arch/ppc/kernel/machine_kexec.c 2005-05-25 13:17:41.000000000 +0200
+++ mm/arch/ppc/kernel/machine_kexec.c 2005-05-25 13:18:06.000000000 +0200
@@ -34,7 +34,7 @@
}
}
-void machine_crash_shutdown(void)
+void machine_crash_shutdown(struct pt_regs *regs)
{
if (ppc_md.machine_crash_shutdown) {
ppc_md.machine_crash_shutdown();
Index: mm/arch/x86_64/kernel/crash.c
===================================================================
--- mm.orig/arch/x86_64/kernel/crash.c 2005-05-25 13:13:18.000000000 +0200
+++ mm/arch/x86_64/kernel/crash.c 2005-05-25 13:15:44.000000000 +0200
@@ -22,7 +22,7 @@
note_buf_t crash_notes[NR_CPUS];
-void machine_crash_shutdown(void)
+void machine_crash_shutdown(struct pt_regs *regs)
{
/* This function is only called after the system
* has paniced or is otherwise in a critical state.
Index: mm/arch/s390/kernel/crash.c
===================================================================
--- mm.orig/arch/s390/kernel/crash.c 2005-05-25 13:13:18.000000000 +0200
+++ mm/arch/s390/kernel/crash.c 2005-05-25 13:15:58.000000000 +0200
@@ -12,6 +12,6 @@
note_buf_t crash_notes[NR_CPUS];
-void machine_crash_shutdown(void)
+void machine_crash_shutdown(struct pt_regs *regs)
{
}
Index: mm/arch/ppc64/kernel/machine_kexec.c
===================================================================
--- mm.orig/arch/ppc64/kernel/machine_kexec.c 2005-05-25 13:13:18.000000000 +0200
+++ mm/arch/ppc64/kernel/machine_kexec.c 2005-05-25 13:15:07.000000000 +0200
@@ -34,7 +34,7 @@
* and if what it will achieve. Letting it be now to compile the code
* in generic kexec environment
*/
-void machine_crash_shutdown(void)
+void machine_crash_shutdown(struct pt_regs *regs)
{
/* do nothing right now */
/* smp_relase_cpus() if we want smp on panic kernel */
Index: mm/include/linux/reboot.h
===================================================================
--- mm.orig/include/linux/reboot.h 2005-05-25 13:13:39.000000000 +0200
+++ mm/include/linux/reboot.h 2005-05-25 13:51:49.000000000 +0200
@@ -52,6 +52,7 @@
extern void machine_power_off(void);
extern void machine_shutdown(void);
+struct pt_regs;
extern void machine_crash_shutdown(struct pt_regs *);
#endif
Index: mm/include/linux/kexec.h
===================================================================
--- mm.orig/include/linux/kexec.h 2005-05-25 13:13:39.000000000 +0200
+++ mm/include/linux/kexec.h 2005-05-25 13:47:47.000000000 +0200
@@ -124,6 +124,8 @@
extern struct resource crashk_res;
#else /* !CONFIG_KEXEC */
+struct pt_regs;
+struct task_struct;
static inline void crash_kexec(struct pt_regs *regs) { }
static inline int kexec_should_crash(struct task_struct *p) { return 0; }
#endif /* CONFIG_KEXEC */
next prev parent reply other threads:[~2005-05-25 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116103798.6153.30.camel@localhost.localdomain>
2005-05-18 12:35 ` [Fastboot] [1/2] kdump: Use real pt_regs from exception Vivek Goyal
2005-05-18 14:51 ` Alexander Nyberg
2005-05-25 9:07 ` Andrew Morton
2005-05-25 12:14 ` Alexander Nyberg [this message]
2005-05-25 13:06 ` Vivek Goyal
2005-05-25 13:14 ` Alexander Nyberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117023296.877.11.camel@localhost.localdomain \
--to=alexn@telia.com \
--cc=akpm@osdl.org \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.