From: Alexander Nyberg <alexn@telia.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Pete Clements <clem@clem.clem-digital.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.12-rc5-git3 fails compile -- acpi_boot_table_init
Date: Sun, 29 May 2005 21:17:40 +0200 [thread overview]
Message-ID: <1117394260.957.12.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0505291157120.10545@ppc970.osdl.org>
> > This is a neverending story
> >
> > linux/acpi.h contains empty declarations for acpi_boot_init() &
> > acpi_boot_table_init() but they are nested inside #ifdef CONFIG_ACPI.
> >
> > So we'll have to #ifdef in arch/i386/kernel/setup.c: setup_arch()
>
> Wouldn't it be much nicer to just fix <linux/acpi.h> instead? Or, if you
> really prefer this, then you should remove the now useless code from
> acpi.h. In either case, this patch looks wrong.
>
There's no question that the patch isn't the correct solution to the
problem, it's a band-aid for a -rc5 kernel. The current acpi include
system doesn't work very well.
Fixing it up for real with the risk of making some arch/config not
compile for a long awaited 2.6.12 and having someone chase me with a
spade isn't something i'm longing to try out. But if you insist...
next prev parent reply other threads:[~2005-05-29 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 12:06 2.6.12-rc5-git3 fails compile -- acpi_boot_table_init Pete Clements
2005-05-28 13:37 ` Alexander Nyberg
2005-05-29 18:58 ` Linus Torvalds
2005-05-29 19:17 ` Alexander Nyberg [this message]
2005-05-31 14:09 ` Steven Cole
2005-05-31 20:00 ` Christian Kujau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117394260.957.12.camel@localhost.localdomain \
--to=alexn@telia.com \
--cc=clem@clem.clem-digital.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.