diff for duplicates of <1117651618.13600.16.camel@localhost> diff --git a/a/1.txt b/N1/1.txt index 42f9fc7..ebc8277 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Wed, 2005-06-01 at 10:48 -0700, Christoph Lameter wrote: > + struct per_cpu_pageset *pset; > + > + /* Do not drain local pagesets */ -> + if (zone = zone_table[numa_node_id()]) +> + if (zone == zone_table[numa_node_id()]) > + continue; > + @@ -13,7 +13,7 @@ number and the zone number (see NODEZONE()). I'd suggest using something like this: - if (zone->zone_pgdat->node_id = numa_node_id()) + if (zone->zone_pgdat->node_id == numa_node_id()) It might be nice to have a zone_node_id() macro that hides this as well. With a macro like that that #defines to 0 when !CONFIG_NUMA, the #ifdef diff --git a/a/content_digest b/N1/content_digest index 6af8751..5b8a5a1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0Pine.LNX.4.62.0506011047060.9277@schroedinger.engr.sgi.com\0" "From\0Dave Hansen <haveblue@us.ibm.com>\0" "Subject\0Re: [PATCH] Periodically drain non local pagesets\0" - "Date\0Wed, 01 Jun 2005 18:46:58 +0000\0" + "Date\0Wed, 01 Jun 2005 11:46:58 -0700\0" "To\0Christoph Lameter <clameter@engr.sgi.com>\0" "Cc\0Andrew Morton <akpm@osdl.org>" linux-mm <linux-mm@kvack.org> @@ -13,7 +13,7 @@ "> + struct per_cpu_pageset *pset;\n" "> +\n" "> + /* Do not drain local pagesets */\n" - "> + if (zone = zone_table[numa_node_id()])\n" + "> + if (zone == zone_table[numa_node_id()])\n" "> + continue;\n" "> +\n" "\n" @@ -24,7 +24,7 @@ "\n" "I'd suggest using something like this:\n" "\n" - "\tif (zone->zone_pgdat->node_id = numa_node_id())\n" + "\tif (zone->zone_pgdat->node_id == numa_node_id())\n" "\n" "It might be nice to have a zone_node_id() macro that hides this as well.\n" "With a macro like that that #defines to 0 when !CONFIG_NUMA, the #ifdef\n" @@ -34,4 +34,4 @@ "\n" -- Dave -b08ef65b62ca0c335a64153713889d131f433aab9837c39ebfa3cdf4e7d0d77c +c9aea1397016a22ba465240fdf3a38f484c0dcd83c61f899657d2035632c5fd0
diff --git a/a/1.txt b/N2/1.txt index 42f9fc7..0f86b54 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ On Wed, 2005-06-01 at 10:48 -0700, Christoph Lameter wrote: > + struct per_cpu_pageset *pset; > + > + /* Do not drain local pagesets */ -> + if (zone = zone_table[numa_node_id()]) +> + if (zone == zone_table[numa_node_id()]) > + continue; > + @@ -13,7 +13,7 @@ number and the zone number (see NODEZONE()). I'd suggest using something like this: - if (zone->zone_pgdat->node_id = numa_node_id()) + if (zone->zone_pgdat->node_id == numa_node_id()) It might be nice to have a zone_node_id() macro that hides this as well. With a macro like that that #defines to 0 when !CONFIG_NUMA, the #ifdef @@ -22,3 +22,9 @@ around that function could probably go away. Also, are you sure that you need the local_irq_en/disable()? -- Dave + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 6af8751..f6188ef 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,7 @@ "ref\0Pine.LNX.4.62.0506011047060.9277@schroedinger.engr.sgi.com\0" "From\0Dave Hansen <haveblue@us.ibm.com>\0" "Subject\0Re: [PATCH] Periodically drain non local pagesets\0" - "Date\0Wed, 01 Jun 2005 18:46:58 +0000\0" + "Date\0Wed, 01 Jun 2005 11:46:58 -0700\0" "To\0Christoph Lameter <clameter@engr.sgi.com>\0" "Cc\0Andrew Morton <akpm@osdl.org>" linux-mm <linux-mm@kvack.org> @@ -13,7 +13,7 @@ "> + struct per_cpu_pageset *pset;\n" "> +\n" "> + /* Do not drain local pagesets */\n" - "> + if (zone = zone_table[numa_node_id()])\n" + "> + if (zone == zone_table[numa_node_id()])\n" "> + continue;\n" "> +\n" "\n" @@ -24,7 +24,7 @@ "\n" "I'd suggest using something like this:\n" "\n" - "\tif (zone->zone_pgdat->node_id = numa_node_id())\n" + "\tif (zone->zone_pgdat->node_id == numa_node_id())\n" "\n" "It might be nice to have a zone_node_id() macro that hides this as well.\n" "With a macro like that that #defines to 0 when !CONFIG_NUMA, the #ifdef\n" @@ -32,6 +32,12 @@ "\n" "Also, are you sure that you need the local_irq_en/disable()? \n" "\n" - -- Dave + "-- Dave\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"aart@kvack.org\"> aart@kvack.org </a>" -b08ef65b62ca0c335a64153713889d131f433aab9837c39ebfa3cdf4e7d0d77c +bdecef719e55e92a05824bd40e00df921bd2daa1e5a710d75a135b958dba22ec
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.