From: Rusty Russell <rusty@rustcorp.com.au>
To: aq <aquynh@gmail.com>
Cc: Xen Dev <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xs.h and xs_lib.h
Date: Sun, 12 Jun 2005 16:36:45 +1000 [thread overview]
Message-ID: <1118558205.31631.2.camel@localhost.localdomain> (raw)
In-Reply-To: <9cde8bff050610013219cd249d@mail.gmail.com>
On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> This patch moves declaration of xs_handle from xs.c to xs.h.
No; why do this? It's opaque for a reason. Originally it was just an
int, but Keir insisted it be an opaque structure. Exposing it binds us
to the current structure again.
> Besides,
> it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> uninstalled them when cleaning up.
xs_lib.h should not be installed in /usr/include!
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2005-06-12 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-10 8:32 [PATCH] xs.h and xs_lib.h aq
2005-06-10 8:31 ` Keir Fraser
2005-06-12 6:36 ` Rusty Russell [this message]
2005-06-12 15:14 ` aq
2005-06-14 0:32 ` Rusty Russell
2005-06-14 4:46 ` aq
2005-06-14 22:49 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118558205.31631.2.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=aquynh@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.