From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] xs.h and xs_lib.h
Date: Tue, 14 Jun 2005 10:32:45 +1000
Message-ID: <1118709165.18549.5.camel@localhost.localdomain>
References: <9cde8bff050610013219cd249d@mail.gmail.com>
	<1118558205.31631.2.camel@localhost.localdomain>
	<9cde8bff0506120814b2ebbe8@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <9cde8bff0506120814b2ebbe8@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: aq <aquynh@gmail.com>
Cc: Xen Dev <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2005-06-13 at 00:14 +0900, aq wrote:
> On 6/12/05, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> > > This patch moves declaration of xs_handle from xs.c to xs.h.
> > 
> > No; why do this?  It's opaque for a reason.  Originally it was just an
> > int, but Keir insisted it be an opaque structure.  Exposing it binds us
> > to the current structure again.
> > 
> > > Besides,
> > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> > > uninstalled them when cleaning up.
> > 
> > xs_lib.h should not be installed in /usr/include!
> 
> i see that, but where should we put this header?

Once the daemon and library are built, it's not necessary for anything.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman