From: Pavel Roskin <proski@gnu.org>
To: git <git@vger.kernel.org>
Subject: [COGITO PATCH] Fixing "cg-help typo" again
Date: Tue, 14 Jun 2005 19:32:47 -0400 [thread overview]
Message-ID: <1118791967.3890.11.camel@dv> (raw)
Hello!
"cg-help typo" is broken again (same symptom - no output) because the
print_help() output is piped through colorize(), which never fails.
I don't know any way to get return status of the first command in a
pipeline, so I changed to code to put print_help() output in a variable,
check status and then pipe the variable contents through colorize().
GNU bash can hold indefinitely much data in variables, and we need a few
kilobytes at most.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/cg-help b/cg-help
--- a/cg-help
+++ b/cg-help
@@ -59,7 +59,8 @@ colorize() {
if [ "$ARGS" ]; then
cmd=$(echo "${ARGS[0]}" | sed 's/^cg-//')
- ( print_help $cmd | colorize ) && exit
+ helpdata="$(print_help $cmd)"
+ [ "$?" = 0 ] && { echo "$helpdata" | colorize; exit 0; }
echo "cg-help: no help available for command \"${ARGS[0]}\""
echo "Call cg-help without any arguments for the list of available commands"
exit 1
--
Regards,
Pavel Roskin
next reply other threads:[~2005-06-14 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 23:32 Pavel Roskin [this message]
2005-06-14 23:43 ` [COGITO PATCH] Fixing "cg-help typo" again Jonas Fonseca
2005-06-15 0:17 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118791967.3890.11.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.