From: Gerald Schaefer <geraldsc@de.ibm.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com
Subject: Re: [PATCH 0/1] VFS: memory leak in do_kern_mount()
Date: Fri, 17 Jun 2005 17:47:22 +0200 [thread overview]
Message-ID: <1119023242.7006.70.camel@thinkpad> (raw)
In-Reply-To: <1119014276.7006.57.camel@thinkpad>
On Fri, 2005-06-17 at 15:17 +0200, Gerald Schaefer wrote:
> [PATCH 0/1] VFS: memory leak in do_kern_mount()
> There is a memory leak during mount when CONFIG_SECURITY is enabled and mount
> options are specified.
>
> Signed-off-by: Gerald Schaefer <geraldsc@de.ibm.com>
> ---
>
> diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
> --- linux-2.6-git/fs/super.c 2005-06-16 20:00:26.000000000 +0200
> +++ linux-2.6-git_xxx/fs/super.c 2005-06-17 14:18:06.000000000 +0200
> @@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
> mnt->mnt_parent = mnt;
> mnt->mnt_namespace = current->namespace;
> up_write(&sb->s_umount);
> + free_secdata(secdata);
> put_filesystem(type);
> return mnt;
> out_sb:
Sorry, there was a whitespace accident and the above patch would not apply.
Here is the fixed version:
diff -pruN linux-2.6-git/fs/super.c linux-2.6-git_xxx/fs/super.c
--- linux-2.6-git/fs/super.c 2005-06-16 20:00:26.000000000 +0200
+++ linux-2.6-git_xxx/fs/super.c 2005-06-17 14:18:06.000000000 +0200
@@ -835,6 +835,7 @@ do_kern_mount(const char *fstype, int fl
mnt->mnt_parent = mnt;
mnt->mnt_namespace = current->namespace;
up_write(&sb->s_umount);
+ free_secdata(secdata);
put_filesystem(type);
return mnt;
out_sb:
next prev parent reply other threads:[~2005-06-17 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-17 13:17 [PATCH 0/1] VFS: memory leak in do_kern_mount() Gerald Schaefer
2005-06-17 15:47 ` Gerald Schaefer [this message]
2005-06-17 19:49 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1119023242.7006.70.camel@thinkpad \
--to=geraldsc@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.