From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, akpm@osdl.org
Subject: Re: PATCH: Fix crashes with hotplug serverworks
Date: Tue, 21 Jun 2005 10:33:40 +0100 [thread overview]
Message-ID: <1119346417.3325.82.camel@localhost.localdomain> (raw)
In-Reply-To: <20050621065221.GA31420@infradead.org>
On Maw, 2005-06-21 at 07:52, Christoph Hellwig wrote:
> Well, because of fake-hotplug we really need to mark every ->probe routine
> and what's called from it __devinit. Debian has patch to do that forever
> but Bart refused to take it.
I'm not surprised from our experience either.
Actually marking all the devices __devinit may be overkill. One approach
that does also seem to work is passing "hotplug yes/no" information when
registering the driver. This is then used to run the ide scan at boot
and avoid registering that driver with the PCI core for hotplug.
A move to __devinit is certainly simpler.
next prev parent reply other threads:[~2005-06-21 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 20:21 PATCH: Fix crashes with hotplug serverworks Alan Cox
2005-06-21 6:52 ` Christoph Hellwig
2005-06-21 8:25 ` Bartlomiej Zolnierkiewicz
2005-06-21 9:33 ` Alan Cox [this message]
2005-06-21 9:59 ` Bartlomiej Zolnierkiewicz
2005-06-21 11:16 ` Alan Cox
2005-06-21 12:11 ` Bartlomiej Zolnierkiewicz
2005-06-21 14:08 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1119346417.3325.82.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.