All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com
Cc: grant_lkml@dodo.com.au
Subject: [PATCH] I2C: adm9240 driver cleanup
Date: Tue, 21 Jun 2005 22:17:44 -0700	[thread overview]
Message-ID: <11194174641411@kroah.com> (raw)
In-Reply-To: <11194174641227@kroah.com>

[PATCH] I2C: adm9240 driver cleanup

This patch adds an info print of detected VRM stolen from Sebastian
Witt's atxp1 sriver.  ADM9240 already has vrm accessor removed.

Write no-op and whitespace fixes removed :)

Couple of comments changed, tested on 2.6.11.9.

Signed-off-by: Grant Coady <gcoady@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit 8e8f9289cc5b781d583d5aed935abf060207bbd3
tree d058803efab6b2f359ca750ec50e73681da3ce8d
parent 937df8df907ce63b0f7e19adf6e3cdef1687fac3
author Grant Coady <grant_lkml@dodo.com.au> Fri, 13 May 2005 20:26:10 +1000
committer Greg Kroah-Hartman <gregkh@suse.de> Tue, 21 Jun 2005 21:51:57 -0700

 drivers/i2c/chips/adm9240.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/chips/adm9240.c b/drivers/i2c/chips/adm9240.c
--- a/drivers/i2c/chips/adm9240.c
+++ b/drivers/i2c/chips/adm9240.c
@@ -165,7 +165,7 @@ struct adm9240_data {
 	s8 temp_high;		/* rw	temp1_max */
 	s8 temp_hyst;		/* rw	temp1_max_hyst */
 	u16 alarms;		/* ro	alarms */
-	u8 aout;		/* rw	analog_out */
+	u8 aout;		/* rw	aout_output */
 	u8 vid;			/* ro	vid */
 	u8 vrm;			/* --	vrm set on startup, no accessor */
 };
@@ -192,7 +192,7 @@ static ssize_t show_##value(struct devic
 }
 show_temp(temp_high, 1000);
 show_temp(temp_hyst, 1000);
-show_temp(temp, 500);
+show_temp(temp, 500); /* 0.5'C per bit */
 
 #define set_temp(value, reg)					\
 static ssize_t set_##value(struct device *dev, const char *buf,	\
@@ -630,6 +630,9 @@ static void adm9240_init_client(struct i
 
 	data->vrm = i2c_which_vrm(); /* need this to report vid as mV */
 
+	dev_info(&client->dev, "Using VRM: %d.%d\n", data->vrm / 10,
+			data->vrm % 10);
+
 	if (conf & 1) { /* measurement cycle running: report state */
 
 		dev_info(&client->dev, "status: config 0x%02x mode %u\n",


  reply	other threads:[~2005-06-22  7:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-22  5:16 [GIT PATCH] I2C patches for 2.6.12 Greg KH
2005-06-22  5:17 ` [PATCH] I2C: Kill address ranges in non-sensors i2c chip drivers Greg KH
2005-06-22  5:17   ` [PATCH] I2C: i2c-vid.h: Support for VID to reg conversion Greg KH
2005-06-22  5:17     ` [PATCH] I2C: Merge unused address lists in some video drivers Greg KH
2005-06-22  5:17       ` [PATCH] I2C: rtc8564.c remove duplicate include Greg KH
2005-06-22  5:17         ` [PATCH] I2C: ds1337 1/4 Greg KH
2005-06-22  5:17           ` [PATCH] I2C: mark all functions static in atxp1 driver Greg KH
2005-06-22  5:17             ` [PATCH] I2C: add new " Greg KH
2005-06-22  5:17               ` [PATCH] I2C: ds1337: i2c_transfer() checking Greg KH
2005-06-22  5:17                 ` [PATCH] I2C: ds1337: Make time format consistent with other RTC drivers Greg KH
2005-06-22  5:17                   ` [PATCH] I2C: ds1337 2/4 Greg KH
2005-06-22  5:17                     ` [PATCH] I2C: ds1337 3/4 Greg KH
2005-06-22  5:17                       ` [PATCH] I2C: ds1337: search by bus number Greg KH
2005-06-22  5:17                         ` [PATCH] ds1337 driver works also with ds1339 chip Greg KH
2005-06-22  5:17                           ` [PATCH] ds1337: export ds1337_do_command Greg KH
2005-06-22  5:17                             ` [PATCH] I2C: add new hardware monitor driver: adm9240 Greg KH
2005-06-22  5:17                               ` [PATCH] I2C: #include <linux/config.h> cleanup Greg KH
2005-06-22  5:17                                 ` [PATCH] I2C: drivers/i2c/*: " Greg KH
2005-06-22  5:17                                   ` [PATCH] I2C: New hardware monitoring driver: w83627ehf Greg KH
2005-06-22  5:17                                     ` [PATCH] I2C: Fix bugs in the new w83627ehf driver Greg KH
2005-06-22  5:17                                       ` [PATCH] I2C: Add support for the LPC47M15x and LPC47M192 chips to smsc47m1 Greg KH
2005-06-22  5:17                                         ` [PATCH] I2C: Allow for sharing of the interrupt line for i2c-mpc.c Greg KH
2005-06-22  5:17                                           ` [PATCH] Spelling fixes for drivers/i2c Greg KH
2005-06-22  5:17                                             ` [PATCH] I2C: Remove redundancy from i2c-core.c Greg KH
2005-06-22  5:17                                               ` [PATCH] I2C: sysfs names: rename to cpu0_vid, take 3 Greg KH
2005-06-22  5:17                                                 ` [PATCH] I2C: Setting w83627hf fan divisor 128 fails Greg KH
2005-06-22  5:17                                                   ` [PATCH] I2C: remove <linux/delay.h> from via686a Greg KH
2005-06-22  5:17                                                     ` [PATCH] I2C: Kill common macro abuse in chip drivers Greg KH
2005-06-22  5:17                                                       ` Greg KH [this message]
2005-06-22  5:17                                                         ` [PATCH] I2C: include of jiffies.h for some i2c drivers Greg KH
2005-06-22  5:17                                                           ` [PATCH] I2C: chips/Kconfig corrections Greg KH
2005-06-22  5:17                                                             ` [PATCH] I2C: driver adm1021: remove die_code Greg KH
2005-06-22  5:17                                                               ` [PATCH] I2C: Coding style cleanups to via686a Greg KH
2005-06-22  5:17                                                                 ` [PATCH] I2C: Spelling fixes for drivers/i2c/algos/i2c-algo-pca.c Greg KH
2005-06-22  5:17                                                                   ` [PATCH] I2C: Kill another macro abuse in via686a Greg KH
2005-06-22  5:17                                                                     ` [PATCH] I2C: fix up some sysfs device attribute file parameters Greg KH
2005-06-22  5:17                                                                       ` [PATCH] I2C: Spelling fixes for drivers/i2c/busses/i2c-parport.c Greg KH
2005-06-22  5:17                                                                         ` [PATCH] I2C: Spelling fixes for drivers/i2c/i2c-core.c Greg KH
2005-06-22  5:17                                                                           ` [PATCH] I2C: Spelling fixes for drivers/i2c/i2c-dev.c Greg KH
2005-06-22  5:17                                                                             ` [PATCH] I2C: add i2c driver for TPS6501x Greg KH
2005-06-22  5:17                                                                               ` [PATCH] i2c: Race fix for i2c-mpc.c Greg KH
2005-06-22  5:17                                                                                 ` [PATCH] I2C: Sensors mailing list has moved Greg KH
2005-06-22  5:17                                                                                   ` [PATCH] I2C: documentation update 1/3 Greg KH
2005-06-22  5:17                                                                                     ` [PATCH] I2C: KConfig update - some EXPERIMENTAL removal Greg KH
2005-06-23 21:12                                                                               ` [PATCH] I2C: add i2c driver for TPS6501x Jean Delvare
2005-06-23 23:13                                                                                 ` [lm-sensors] " Jean Delvare
2005-06-29  3:21                                                                                 ` david-b
2005-06-22  7:37                                               ` [PATCH] I2C: Remove redundancy from i2c-core.c Thomas Schneller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11194174641411@kroah.com \
    --to=gregkh@suse.de \
    --cc=grant_lkml@dodo.com.au \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@Stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.