From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Doug Warzecha <Douglas_Warzecha@dell.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
abhay_salunke@dell.com, matt_domsch@dell.com
Subject: Re: [PATCH][RFC 2] char: Add Dell Systems Management Base driver
Date: Mon, 27 Jun 2005 01:29:28 +0100 [thread overview]
Message-ID: <1119832167.28649.55.camel@localhost.localdomain> (raw)
In-Reply-To: <20050626230544.GA6121@sysman-doug.us.dell.com>
> +
> + /* generate SMI */
> + asm("outb %b0,%w1" : :
> + "a" (ci_cmd->command_code),
> + "d" (ci_cmd->command_address),
> + "b" (command_buffer_phys_addr),
> + "c" (ci_cmd->signature));
> +
Is there a reason this bit is asm not an outb() macro. If its needed in
asm for the SMI behaviour then document that fact so nobody "optimises"
it.
> + unsigned long size;
> + int ret;
> + size = sizeof(struct dcdbas_ioctl_hdr) + hdr.data_size;
Can this not underflow if hdr.data_size is passed in very large
There are a few others like that which look like they might need
overflow checks.
next prev parent reply other threads:[~2005-06-27 0:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 23:05 [PATCH][RFC 2] char: Add Dell Systems Management Base driver Doug Warzecha
2005-06-27 0:29 ` Alan Cox [this message]
2005-06-27 1:53 ` Brian Gerst
2005-06-27 3:10 ` randy_dunlap
2005-06-27 20:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1119832167.28649.55.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Douglas_Warzecha@dell.com \
--cc=abhay_salunke@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.