From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261421AbVF0KRG (ORCPT ); Mon, 27 Jun 2005 06:17:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261431AbVF0KRG (ORCPT ); Mon, 27 Jun 2005 06:17:06 -0400 Received: from relay.rost.ru ([80.254.111.11]:62150 "EHLO relay.rost.ru") by vger.kernel.org with ESMTP id S261421AbVF0KQL (ORCPT ); Mon, 27 Jun 2005 06:16:11 -0400 Subject: [PATCH] 2.6.12-mm2, consolidate CONFIG_WATCHDOG_NOWAYOUT handling In-Reply-To: X-Mailer: gregkh_patchbomb_levon_offspring Date: Mon, 27 Jun 2005 14:16:08 +0400 Message-Id: <1119867368540@donpac.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: Andrew Morton , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7BIT From: Andrey Panin Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello, attached trivial patch removes #ifdef CONFIG_WATCHDOG_NOWAYOUT mess duplicated in almost every watchdog driver and replaces it with common define in linux/watchdog.h. Please take a look. Signed-off-by: Andrey Panin include/linux/watchdog.h | 10 ++++++++++ drivers/char/ipmi/ipmi_watchdog.c | 6 +----- drivers/char/watchdog/acquirewdt.c | 7 +------ drivers/char/watchdog/advantechwdt.c | 7 +------ drivers/char/watchdog/alim1535_wdt.c | 7 +------ drivers/char/watchdog/alim7101_wdt.c | 7 +------ drivers/char/watchdog/eurotechwdt.c | 7 +------ drivers/char/watchdog/i8xx_tco.c | 7 +------ drivers/char/watchdog/ib700wdt.c | 7 +------ drivers/char/watchdog/indydog.c | 7 +------ drivers/char/watchdog/ixp2000_wdt.c | 6 +----- drivers/char/watchdog/ixp4xx_wdt.c | 6 +----- drivers/char/watchdog/machzwd.c | 7 +------ drivers/char/watchdog/mixcomwd.c | 7 +------ drivers/char/watchdog/pcwd.c | 7 +------ drivers/char/watchdog/pcwd_pci.c | 7 +------ drivers/char/watchdog/pcwd_usb.c | 7 +------ drivers/char/watchdog/s3c2410_wdt.c | 7 +------ drivers/char/watchdog/sa1100_wdt.c | 6 +----- drivers/char/watchdog/sbc60xxwdt.c | 7 +------ drivers/char/watchdog/sc1200wdt.c | 7 +------ drivers/char/watchdog/sc520_wdt.c | 7 +------ drivers/char/watchdog/scx200_wdt.c | 6 +----- drivers/char/watchdog/shwdt.c | 6 +----- drivers/char/watchdog/softdog.c | 7 +------ drivers/char/watchdog/w83627hf_wdt.c | 7 +------ drivers/char/watchdog/w83877f_wdt.c | 7 +------ drivers/char/watchdog/wafer5823wdt.c | 7 +------ drivers/char/watchdog/wdt.c | 7 +------ drivers/char/watchdog/wdt977.c | 7 +------ drivers/char/watchdog/wdt_pci.c | 7 +------ drivers/s390/char/vmwatchdog.c | 6 +----- 32 files changed, 41 insertions(+), 179 deletions(-) diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/include/linux/watchdog.h linux-2.6.12-mm2/include/linux/watchdog.h --- linux-2.6.12-mm2.vanilla/include/linux/watchdog.h 2005-06-27 13:33:16.000000000 +0400 +++ linux-2.6.12-mm2/include/linux/watchdog.h 2005-06-27 13:35:00.000000000 +0400 @@ -47,4 +47,14 @@ struct watchdog_info { #define WDIOS_ENABLECARD 0x0002 /* Turn on the watchdog timer */ #define WDIOS_TEMPPANIC 0x0004 /* Kernel panic on temperature trip */ +#ifdef __KERNEL__ + +#ifdef CONFIG_WATCHDOG_NOWAYOUT +#define WATCHDOG_NOWAYOUT 1 +#else +#define WATCHDOG_NOWAYOUT 0 +#endif + +#endif /* __KERNEL__ */ + #endif /* ifndef _LINUX_WATCHDOG_H */ diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/ipmi/ipmi_watchdog.c linux-2.6.12-mm2/drivers/char/ipmi/ipmi_watchdog.c --- linux-2.6.12-mm2.vanilla/drivers/char/ipmi/ipmi_watchdog.c 2005-06-27 13:30:45.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/ipmi/ipmi_watchdog.c 2005-06-27 13:34:59.000000000 +0400 @@ -131,11 +131,7 @@ #define WDIOC_GET_PRETIMEOUT _IOW(WATCHDOG_IOCTL_BASE, 22, int) #endif -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout; -#endif +static int nowayout = WATCHDOG_NOWAYOUT; static ipmi_user_t watchdog_user = NULL; diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/acquirewdt.c linux-2.6.12-mm2/drivers/char/watchdog/acquirewdt.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/acquirewdt.c 2005-06-27 13:30:43.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/acquirewdt.c 2005-06-27 13:35:00.000000000 +0400 @@ -82,12 +82,7 @@ static int wdt_start = 0x443; module_param(wdt_start, int, 0); MODULE_PARM_DESC(wdt_start, "Acquire WDT 'start' io port (default 0x443)"); -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif - +static int nowayout = WATCHDOG_NOWAYOUT; module_param(nowayout, int, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=CONFIG_WATCHDOG_NOWAYOUT)"); diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/advantechwdt.c linux-2.6.12-mm2/drivers/char/watchdog/advantechwdt.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/advantechwdt.c 2005-06-27 13:30:43.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/advantechwdt.c 2005-06-27 13:35:00.000000000 +0400 @@ -73,12 +73,7 @@ static int timeout = WATCHDOG_TIMEOUT; / module_param(timeout, int, 0); MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds. 1<= timeout <=63, default=" __MODULE_STRING(WATCHDOG_TIMEOUT) "."); -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif - +static int nowayout = WATCHDOG_NOWAYOUT; module_param(nowayout, int, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=CONFIG_WATCHDOG_NOWAYOUT)"); diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/alim1535_wdt.c linux-2.6.12-mm2/drivers/char/watchdog/alim1535_wdt.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/alim1535_wdt.c 2005-06-27 13:30:43.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/alim1535_wdt.c 2005-06-27 13:35:00.000000000 +0400 @@ -38,12 +38,7 @@ static int timeout = WATCHDOG_TIMEOUT; module_param(timeout, int, 0); MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds. (0 #include -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif +static int nowayout = WATCHDOG_NOWAYOUT; static unsigned int heartbeat = 60; /* (secs) Default is 1 minute */ static unsigned long wdt_status; diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/ixp4xx_wdt.c linux-2.6.12-mm2/drivers/char/watchdog/ixp4xx_wdt.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/ixp4xx_wdt.c 2005-06-27 13:30:44.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/ixp4xx_wdt.c 2005-06-27 13:35:00.000000000 +0400 @@ -27,11 +27,7 @@ #include #include -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif +static int nowayout = WATCHDOG_NOWAYOUT; static int heartbeat = 60; /* (secs) Default is 1 minute */ static unsigned long wdt_status; static unsigned long boot_status; diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/machzwd.c linux-2.6.12-mm2/drivers/char/watchdog/machzwd.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/machzwd.c 2005-06-27 13:30:42.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/machzwd.c 2005-06-27 13:35:00.000000000 +0400 @@ -94,12 +94,7 @@ MODULE_DESCRIPTION("MachZ ZF-Logic Watch MODULE_LICENSE("GPL"); MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif - +static int nowayout = WATCHDOG_NOWAYOUT; module_param(nowayout, int, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=CONFIG_WATCHDOG_NOWAYOUT)"); diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/mixcomwd.c linux-2.6.12-mm2/drivers/char/watchdog/mixcomwd.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/mixcomwd.c 2005-06-27 13:30:43.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/mixcomwd.c 2005-06-27 13:35:00.000000000 +0400 @@ -62,12 +62,7 @@ static int mixcomwd_timer_alive; static DEFINE_TIMER(mixcomwd_timer, NULL, 0, 0); static char expect_close; -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif - +static int nowayout = WATCHDOG_NOWAYOUT; module_param(nowayout, int, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=CONFIG_WATCHDOG_NOWAYOUT)"); diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/pcwd.c linux-2.6.12-mm2/drivers/char/watchdog/pcwd.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/pcwd.c 2005-06-27 13:30:42.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/pcwd.c 2005-06-27 13:35:00.000000000 +0400 @@ -146,12 +146,7 @@ static int heartbeat = WATCHDOG_HEARTBEA module_param(heartbeat, int, 0); MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds. (2<=heartbeat<=7200, default=" __MODULE_STRING(WATCHDOG_HEARTBEAT) ")"); -#ifdef CONFIG_WATCHDOG_NOWAYOUT -static int nowayout = 1; -#else -static int nowayout = 0; -#endif - +static int nowayout = WATCHDOG_NOWAYOUT; module_param(nowayout, int, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=CONFIG_WATCHDOG_NOWAYOUT)"); diff -urdpNX /usr/share/dontdiff linux-2.6.12-mm2.vanilla/drivers/char/watchdog/pcwd_pci.c linux-2.6.12-mm2/drivers/char/watchdog/pcwd_pci.c --- linux-2.6.12-mm2.vanilla/drivers/char/watchdog/pcwd_pci.c 2005-06-27 13:30:42.000000000 +0400 +++ linux-2.6.12-mm2/drivers/char/watchdog/pcwd_pci.c 2005-06-27 13:35:00.000000000 +0400 @@ -103,12 +103,7 @@ static int heartbeat = WATCHDOG_HEARTBEA module_param(heartbeat, int, 0); MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds. (0");