All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: FYI: 2.6.11 XenLinux has issues with x86-64 ia32 emulation compilation on gcc4
Date: Mon, 27 Jun 2005 14:16:54 -0500	[thread overview]
Message-ID: <1119899814.2538.21.camel@thinkpad> (raw)

Since IA32 emulation is on by default in the compilation (and it should
be) building the latest x86-64 2.6.11 Xenlinux in the Xen tree with
GCC4:

  SYSCALL arch/xen/x86_64/ia32/vsyscall-syscall.so
  CC      arch/xen/x86_64/ia32/syscall32.o
  CC      arch/xen/x86_64/ia32/sys_ia32.o
  CC      arch/xen/x86_64/ia32/ia32_ioctl.o
In file included from fs/compat_ioctl.c:69,
                 from arch/xen/x86_64/ia32/ia32_ioctl.c:14:
include/linux/i2c.h:58: error: array type has incomplete element type
include/linux/i2c.h:197: error: array type has incomplete element type
make[4]: *** [arch/xen/x86_64/ia32/ia32_ioctl.o] Error 1
make[3]: *** [arch/xen/x86_64/ia32] Error 2
make[3]: Leaving directory `/xen/xen-unstable/linux-2.6.11-xen0'
make[2]: *** [build] Error 2
make[2]: Leaving directory `/xen/xen-unstable'
make[1]: *** [linux-2.6-xen0-build] Error 2
make[1]: Leaving directory `/xen/xen-unstable
make: *** [kernels] Error 1


This is caused by an issue in include/linux/i2c.h in 2.6.11 where you
have:

Line 58: 
extern int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg
msg[],int num);

Line 197:

int (*master_xfer)(struct i2c_adapter *adap,struct i2c_msg msgs[],
                           int num);

Both want to take in "struct i2c_msg msgs[]" and gcc4 doesn't like this.
The fix for this is to not look for an array of and use a pointer. Well
looking at the Linux 2.6.12 code they changed the code base to do this:

Line 58:
extern int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
int num);

Line 194:
int (*master_xfer)(struct i2c_adapter *adap,struct i2c_msg *msgs,
                           int num);


Not sure if this is gcc4 specific..but since no one has reported the
build breaking I think it is. From what I see the fix to this is to turn
off ia32 emulation if you are using gcc4, or hack up fs/ otherwise wait
till 2.6.11 Xenlinux gets an upgrade to 2.6.12.


-- 
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)

             reply	other threads:[~2005-06-27 19:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-27 19:16 Jerone Young [this message]
2005-06-27 19:22 ` FYI: 2.6.11 XenLinux has issues with x86-64 ia32 emulation compilation on gcc4 Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1119899814.2538.21.camel@thinkpad \
    --to=jyoung5@us.ibm.com \
    --cc=jun.nakajima@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.