From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, Eric Biederman <ebiederm@xmission.com>,
Olaf Hering <olh@suse.de>
Subject: Re: [PATCH] use correct register names in arch/ppc/kernel/relocate_kernel.S
Date: Thu, 30 Jun 2005 09:54:44 +1000 [thread overview]
Message-ID: <1120089284.31924.33.camel@gaston> (raw)
In-Reply-To: <20750c905c7c0f2eccc3eba6dc1421db@kernel.crashing.org>
On Wed, 2005-06-29 at 20:08 +0200, Segher Boessenkool wrote:
> > --- linux-2.6.13-rc1.orig/arch/ppc/kernel/relocate_kernel.S
> > +++ linux-2.6.13-rc1/arch/ppc/kernel/relocate_kernel.S
> > @@ -34,9 +34,9 @@ relocate_new_kernel:
> >
> > mr r8, r0
> > ori r8, r8, MSR_RI|MSR_ME
> > - mtspr SRR1, r8
> > + mtspr SPRN_SRR1, r8
> > addi r8, r4, 1f - relocate_new_kernel
> > - mtspr SRR0, r8
> > + mtspr SPRN_SRR0, r8
> > sync
> > rfi
>
> Or just mtsrr0 c.q. mtsrr1
They are lovely but shits me when I grep for SPRN_SRR0 :) I tend to
prefer consistency here and so if we start using mtsrr0/1, then we
should change the whole kernel at once and not have a mix of SPRN_* and
mt*
Ben.
prev parent reply other threads:[~2005-06-30 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 13:01 [PATCH] use correct register names in arch/ppc/kernel/relocate_kernel.S Olaf Hering
2005-06-29 18:08 ` Segher Boessenkool
2005-06-29 23:54 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120089284.31924.33.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olh@suse.de \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.