From: aLeJ <fuzzy.alej@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] fs/smbfs/proc.c -> replace direct assignment with
Date: Thu, 30 Jun 2005 17:53:54 +0000 [thread overview]
Message-ID: <1120160937.26352.3.camel@localhost> (raw)
In-Reply-To: <1120126573.24539.6.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
> the memory barrier is really necessary (as pointed out earlier in the list
> by Nishanth Aravamudan)? if not, __set_current_state does the job.
>
> I'd appreciate some notes/thoughts/tips/whatever on which conditions a
> memory barrier is really needed, or, more clearly, when the absence of a
> memory barrier breaks stuff.
>
> TIA :)
As said in the TODO:
"...
Don't forget to set_current_state(TASK_{,UN}INTERRUPTIBLE); before
schedule*().
..."
And in this case, it is just before schedule, so I considered to change it.
Maybe the use of __set_current is for places where there is not schedule?
(Just a try :p)
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-06-30 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-30 8:28 [KJ] fs/smbfs/proc.c -> replace direct assignment with aLeJ
2005-06-30 8:28 ` aLeJ
2005-06-30 16:12 ` Ricardo Nabinger Sanchez
2005-06-30 17:53 ` aLeJ [this message]
2005-06-30 18:39 ` Nishanth Aravamudan
2005-06-30 20:03 ` aLeJ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120160937.26352.3.camel@localhost \
--to=fuzzy.alej@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.