From: Robert Love <rml@novell.com>
To: Roland Dreier <rolandd@cisco.com>
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] inotify: fsnotify.h: use kstrdup
Date: Fri, 01 Jul 2005 19:36:16 -0400 [thread overview]
Message-ID: <1120260976.7270.23.camel@phantasy> (raw)
In-Reply-To: <52ekai15bi.fsf@topspin.com>
On Fri, 2005-07-01 at 16:20 -0700, Roland Dreier wrote:
> Why not just convert all calls of fsnotify_oldname_init() to kstrdup()
> and delete the inline function? The wrapper isn't adding much beyond
> hard-coding GFP_KERNEL.
Good idea, but the function is different if !CONFIG_INOTIFY. It exists
to save us some ugly ifdefs in the source.
Robert Love
next prev parent reply other threads:[~2005-07-01 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-01 22:55 [-mm patch] inotify: fsnotify.h: use kstrdup Adrian Bunk
2005-07-01 23:20 ` Roland Dreier
2005-07-01 23:28 ` Adrian Bunk
2005-07-01 23:36 ` Robert Love [this message]
2005-07-01 23:36 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120260976.7270.23.camel@phantasy \
--to=rml@novell.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.