From: Hal Rosenstock <halr@voltaire.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 3/27] Add MAD helper functions
Date: 11 Jul 2005 12:58:43 -0400 [thread overview]
Message-ID: <1121100534.4389.4609.camel@hal.voltaire.com> (raw)
In-Reply-To: <200507112029.26890.adobriyan@gmail.com>
On Mon, 2005-07-11 at 12:29, Alexey Dobriyan wrote:
> On Monday 11 July 2005 19:30, Hal Rosenstock wrote:
> > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote:
> > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote:
> > > > Add new helper routines for allocating MADs for sending and formatting
> > > > a send WR.
> > >
> > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c
> > > > +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c
> > > ^^^^^^^^^^^
> > > Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...].
> >
> > Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ?
>
> I'd wait for comments and then resubmit clean series which can be applied
> with patch -p1.
>
> > > > +struct ib_mad_send_buf * ib_create_send_mad(struct ib_mad_agent *mad_agent,
> > > > + u32 remote_qpn, u16 pkey_index,
> > > > + struct ib_ah *ah,
> > > > + int hdr_len, int data_len,
> > > > + int gfp_mask)
> > >
> > > unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings
> > > is not a reason to add more.
> >
> > I'll fix this in a subsequent patch. Is that OK ?
>
> If Andrew will fix patches locally, OK.
I will work this into the resubmitted patches.
-- Hal
next prev parent reply other threads:[~2005-07-11 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-11 13:48 [PATCH 3/27] Add MAD helper functions Hal Rosenstock
2005-07-11 14:39 ` Alexey Dobriyan
2005-07-11 15:30 ` Hal Rosenstock
2005-07-11 16:05 ` [openib-general] " Nishanth Aravamudan
2005-07-11 16:14 ` Hal Rosenstock
2005-07-11 16:29 ` Alexey Dobriyan
2005-07-11 16:58 ` Hal Rosenstock [this message]
2005-07-11 17:52 ` [openib-general] " Tom Duffy
2005-07-11 18:38 ` Alexey Dobriyan
2005-07-12 21:32 ` Tom Duffy
2005-07-12 22:17 ` Michael S. Tsirkin
2005-07-12 22:48 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121100534.4389.4609.camel@hal.voltaire.com \
--to=halr@voltaire.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.