From: Marcel Holtmann <marcel@holtmann.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: laforge@netfilter.org, netdev@vger.kernel.org,
netfilter-devel@lists.netfilter.org, wensong@linux-vs.org
Subject: Re: [PATCH] reduce netfilte sk_buff enlargement
Date: Sat, 23 Jul 2005 03:36:20 +0200 [thread overview]
Message-ID: <1122082580.5878.3.camel@notepaq> (raw)
In-Reply-To: <20050722.155411.32722751.davem@davemloft.net>
Hi David,
> > I found the problem. The hci_usb is using the cb[] by itself and so
> > overwriting the pkt_type value. The attached patch works for me with the
> > hci_usb driver. However I haven't converted all other drivers and
> > checked them. This won't happen until I am back home, because I don't
> > have any of these devices with me around. However it looks like this
> > seems to work without any problems.
>
> Great. I'll wait until you get back and code up an updated
> patch that takes care of all of the drivers.
actually the patch is ready by now and hci_usb and hci_vhci are tested.
The tests for the other drivers have to wait at least until first week
of August. However since it seems to work even with 2.6.13-rc3, I don't
see any reason to wait with the inclusion. If you are serious with the
shrinking of the sk_buff, I can send you the final patch along with my
pending patches for 2.6.13.
Regards
Marcel
next prev parent reply other threads:[~2005-07-23 1:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-16 21:40 [PATCH] reduce netfilte sk_buff enlargement Harald Welte
2005-07-19 3:31 ` David S. Miller
2005-07-19 7:18 ` Jan Engelhardt
2005-07-19 7:23 ` David S. Miller
2005-07-20 13:23 ` Harald Welte
2005-07-20 15:43 ` Wensong Zhang
2005-07-20 21:35 ` Patrick McHardy
2005-07-20 18:43 ` David S. Miller
2005-07-21 18:20 ` Marcel Holtmann
2005-07-21 20:12 ` David S. Miller
2005-07-21 21:42 ` Marcel Holtmann
2005-07-21 22:10 ` David S. Miller
2005-07-21 22:29 ` David S. Miller
2005-07-21 23:49 ` Marcel Holtmann
2005-07-21 23:52 ` David S. Miller
2005-07-22 0:26 ` Marcel Holtmann
2005-07-22 22:54 ` David S. Miller
2005-07-23 1:36 ` Marcel Holtmann [this message]
2005-07-25 2:18 ` David S. Miller
2005-07-22 8:34 ` Amin Azez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1122082580.5878.3.camel@notepaq \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=laforge@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.