From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>
Subject: Re: [RFC][PATCH] libata ATAPI alignment
Date: Fri, 29 Jul 2005 14:38:54 +0100 [thread overview]
Message-ID: <1122644334.13581.42.camel@localhost.localdomain> (raw)
In-Reply-To: <20050729050654.GA10413@havoc.gtf.org>
On Gwe, 2005-07-29 at 01:06 -0400, Jeff Garzik wrote:
> So, one thing that's terribly ugly about SATA ATAPI is that we need to
> pad DMA transfers to the next 32-bit boundary, if the length is not
> evenly divisible by 4.
Looks good and avoids the special case leaking into the core code.
> Complicating matters, we currently must support two methods of data
> buffer submission: a single kernel virtual address, or a struct
> scatterlist.
For the moment - also you turn the single buffer into a one entry sglist
so its not to bad.
> Review is requested by any and all parties, as well as suggestions for
> a prettier approach.
I'd pull the code into seperate functions but thats my only real
comment.
next prev parent reply other threads:[~2005-07-29 13:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 5:06 [RFC][PATCH] libata ATAPI alignment Jeff Garzik
2005-07-29 13:38 ` Alan Cox [this message]
2005-08-02 8:27 ` Jens Axboe
2005-08-02 14:31 ` Jeff Garzik
2005-08-07 5:48 ` Tejun Heo
2005-08-07 5:53 ` [PATCH 1/2] sata: fix sata_sx4 dma_prep to not use sg->length Tejun Heo
2005-08-10 21:24 ` Jeff Garzik
2005-08-07 5:58 ` Rd: [PATCH 2/2] sata: implement ATAPI alignment adjustment Tejun Heo
2005-08-07 6:17 ` [PATCH 3] sata: restore sg on setup failure Tejun Heo
2005-08-19 3:49 ` libata error handling Jeff Garzik
2005-08-19 5:40 ` Tejun Heo
2005-08-19 5:54 ` Jeff Garzik
2005-08-19 19:00 ` Luben Tuikov
2005-08-19 18:46 ` Luben Tuikov
2005-08-19 19:38 ` Patrick Mansfield
2005-08-19 20:03 ` Luben Tuikov
2005-08-19 20:11 ` Patrick Mansfield
2005-08-19 20:43 ` Luben Tuikov
2005-08-19 21:10 ` Patrick Mansfield
2005-08-19 22:37 ` Luben Tuikov
2005-08-19 20:29 ` Mike Anderson
2005-08-19 21:02 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1122644334.13581.42.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.