From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC][PATCH 3/3] drm/bridge: adv7511: Enable HPD interrupts to support hotplug and improve monitor detection Date: Tue, 22 Nov 2016 10:29:30 +0200 Message-ID: <11227748.KeIGuHD5tB@avalon> References: <1479775052-28194-1-git-send-email-john.stultz@linaro.org> <1479775052-28194-4-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A2006E1E5 for ; Tue, 22 Nov 2016 08:29:13 +0000 (UTC) In-Reply-To: <1479775052-28194-4-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDIxIE5vdiAyMDE2 IDE2OjM3OjMyIEpvaG4gU3R1bHR6IHdyb3RlOgo+IEZyb206IEFyY2hpdCBUYW5lamEgPGFyY2hp dHRAY29kZWF1cm9yYS5vcmc+Cj4gCj4gT24gc29tZSBhZHY3NTExIGltcGxlbWVudGF0aW9ucywg d2UgY2FuIGdldCBzb21lIHNwdXJpb3VzCj4gZGlzY29ubmVjdCBzaWduYWxzIHdoaWNoIGNhbiBj YXVzZSBtb25pdG9yIHByb2JpbmcgdG8gZmFpbC4KPiAKPiBUaGlzIHBhdGNoIGVuYWJsZXMgSFBE IChob3QgcGx1ZyBkZXRlY3QpIGludGVycnVwdCBzdXBwb3J0Cj4gd2hpY2ggYWxsb3dzIHRoZSBt b25pdG9yIHRvIGJlIHByb3Blcmx5IHJlLWluaXRpYWxpemVkIHdoZW4KPiB0aGUgc3B1cmlvdXMg ZGlzY29ubmVjdCBzaWduYWwgZ29lcyBhd2F5Lgo+IAo+IFRoaXMgYWxzbyBlbmFibGVzIHByb3Bl ciBob3RwbHVnIHN1cHBvcnQuCj4gCj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5p ZT4KPiBDYzogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4KPiBDYzogV29s ZnJhbSBTYW5nIDx3c2ErcmVuZXNhc0BzYW5nLWVuZ2luZWVyaW5nLmNvbT4KPiBDYzogTGFycy1Q ZXRlciBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxh dXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IE9yaWdpbmFsbHktYnk6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29k ZWF1cm9yYS5vcmc+Cj4gW2pzdHVsdHo6IEFkZGVkIHByb3BlciBjb21taXQgbWVzc2FnZV0KPiBT aWduZWQtb2ZmLWJ5OiBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4KClRoaXMg bG9va3MgZ29vZCB0byBtZS4KCkFja2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBp bmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdl L2Fkdjc1MTEvYWR2NzUxMV9kcnYuYyB8IDYgKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9icmlk Z2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jIGluZGV4IDIxMTRhNGMuLjg4OWNmMzYKPiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jCj4gQEAgLTMz OCw3ICszMzgsNyBAQCBzdGF0aWMgdm9pZCBfX2Fkdjc1MTFfcG93ZXJfb24oc3RydWN0IGFkdjc1 MTEgKmFkdjc1MTEpCj4gIAkJICogU3RpbGwsIGxldCdzIGJlIHNhZmUgYW5kIHN0aWNrIHRvIHRo ZSBkb2N1bWVudGF0aW9uLgo+ICAJCSAqLwo+ICAJCXJlZ21hcF93cml0ZShhZHY3NTExLT5yZWdt YXAsIEFEVjc1MTFfUkVHX0lOVF9FTkFCTEUoMCksCj4gLQkJCSAgICAgQURWNzUxMV9JTlQwX0VE SURfUkVBRFkpOwo+ICsJCQkgICAgIEFEVjc1MTFfSU5UMF9FRElEX1JFQURZIHwgQURWNzUxMV9J TlQwX0hQRCk7Cj4gIAkJcmVnbWFwX3dyaXRlKGFkdjc1MTEtPnJlZ21hcCwgQURWNzUxMV9SRUdf SU5UX0VOQUJMRSgxKSwKPiAgCQkJICAgICBBRFY3NTExX0lOVDFfRERDX0VSUk9SKTsKPiAgCX0K PiBAQCAtODI1LDYgKzgyNSwxMCBAQCBzdGF0aWMgaW50IGFkdjc1MTFfYnJpZGdlX2F0dGFjaChz dHJ1Y3QgZHJtX2JyaWRnZQo+ICpicmlkZ2UpIGlmIChhZHYtPnR5cGUgPT0gQURWNzUzMykKPiAg CQlyZXQgPSBhZHY3NTMzX2F0dGFjaF9kc2koYWR2KTsKPiAKPiArCWlmIChhZHYtPmkyY19tYWlu LT5pcnEpCj4gKwkJcmVnbWFwX3dyaXRlKGFkdi0+cmVnbWFwLCBBRFY3NTExX1JFR19JTlRfRU5B QkxFKDApLAo+ICsJCQkJQURWNzUxMV9JTlQwX0hQRCk7Cj4gKwo+ICAJcmV0dXJuIHJldDsKPiAg fQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619AbcKVI3O (ORCPT ); Tue, 22 Nov 2016 03:29:14 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:33661 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755527AbcKVI3N (ORCPT ); Tue, 22 Nov 2016 03:29:13 -0500 From: Laurent Pinchart To: John Stultz Cc: lkml , Archit Taneja , David Airlie , Wolfram Sang , Lars-Peter Clausen , dri-devel@lists.freedesktop.org Subject: Re: [RFC][PATCH 3/3] drm/bridge: adv7511: Enable HPD interrupts to support hotplug and improve monitor detection Date: Tue, 22 Nov 2016 10:29:30 +0200 Message-ID: <11227748.KeIGuHD5tB@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1479775052-28194-4-git-send-email-john.stultz@linaro.org> References: <1479775052-28194-1-git-send-email-john.stultz@linaro.org> <1479775052-28194-4-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patch. On Monday 21 Nov 2016 16:37:32 John Stultz wrote: > From: Archit Taneja > > On some adv7511 implementations, we can get some spurious > disconnect signals which can cause monitor probing to fail. > > This patch enables HPD (hot plug detect) interrupt support > which allows the monitor to be properly re-initialized when > the spurious disconnect signal goes away. > > This also enables proper hotplug support. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Originally-by: Archit Taneja > [jstultz: Added proper commit message] > Signed-off-by: John Stultz This looks good to me. Acked-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 2114a4c..889cf36 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -338,7 +338,7 @@ static void __adv7511_power_on(struct adv7511 *adv7511) > * Still, let's be safe and stick to the documentation. > */ > regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0), > - ADV7511_INT0_EDID_READY); > + ADV7511_INT0_EDID_READY | ADV7511_INT0_HPD); > regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(1), > ADV7511_INT1_DDC_ERROR); > } > @@ -825,6 +825,10 @@ static int adv7511_bridge_attach(struct drm_bridge > *bridge) if (adv->type == ADV7533) > ret = adv7533_attach_dsi(adv); > > + if (adv->i2c_main->irq) > + regmap_write(adv->regmap, ADV7511_REG_INT_ENABLE(0), > + ADV7511_INT0_HPD); > + > return ret; > } -- Regards, Laurent Pinchart