From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Frank van Maarseveen <frankvm@frankvm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: bug in arch/ppc/boot/common/util.S: cmplwi cr0,r3,r4 ?
Date: Thu, 04 Aug 2005 11:44:08 +0200 [thread overview]
Message-ID: <1123148649.30257.59.camel@gaston> (raw)
In-Reply-To: <20050803131848.GA10954@janus>
On Wed, 2005-08-03 at 15:18 +0200, Frank van Maarseveen wrote:
> I think "cmplwi" expects an immediate vale as last operand
> around line 255 of arch/ppc/boot/common/util.S:
>
> addi r4,r4,_etext@l # r8 = &_etext
> 1: dcbf r0,r3 # Flush the data cache
> icbi r0,r3 # Invalidate the instruction cache
> addi r3,r3,0x10 # Increment by one cache line
> cmplwi cr0,r3,r4 # Are we at the end yet?
> ^^
> blt 1b # No, keep flushing and invalidating
>
> I guess it should have been:
>
> cmplw cr0,r3,r4 # Are we at the end yet?
Yup, looks like a real bug to me, Tom ?
Ben.
next prev parent reply other threads:[~2005-08-04 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-03 13:18 bug in arch/ppc/boot/common/util.S: cmplwi cr0,r3,r4 ? Frank van Maarseveen
2005-08-04 9:44 ` Benjamin Herrenschmidt [this message]
2005-08-09 0:50 ` Tom Rini
2005-08-09 2:20 ` Hollis Blanchard
2005-08-09 8:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123148649.30257.59.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=frankvm@frankvm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.