All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vernon Mauery <vernux@us.ibm.com>
To: Corey Minyard <minyard@mvista.com>
Cc: Rusty Russell <trivial@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: dmi_table counting in ipmi_si_intf.c
Date: Tue, 09 Aug 2005 16:43:17 -0700	[thread overview]
Message-ID: <1123630997.3246.18.camel@bluecow> (raw)

I am working on getting one of the IBM blades to use ipmi and have run
into a problem.  The driver doesn't load because it says it can't find
the device.

dmidecode shows that there are 39 entries and that the last one is the
BMC.  I looked into dmi_table and noticed that it parses the table by
length and by number of entries.  But I found that it goes from i=1 to
i<num.  This causes it to skip the last entry in the table.  Is there a
reason it is i=1 instead of i=0?  or for that matter i<num instead of
i<=num?

Ensure that all dmi table entries get parsed.

Signed-off-by: Vernon Mauery <vernux@us.ibm.com>
---

diff -uar a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
--- a/drivers/char/ipmi/ipmi_si_intf.c	2005-08-09 08:11:41.000000000 -0700
+++ b/drivers/char/ipmi/ipmi_si_intf.c	2005-08-09 08:12:51.000000000 -0700
@@ -1690,7 +1690,7 @@ static int dmi_table(u32 base, int len, 
 	u8 		  __iomem *buf;
 	struct dmi_header __iomem *dm;
 	u8 		  __iomem *data;
-	int 		  i=1;
+	int 		  i=0;
 	int		  status=-1;
 	int               intf_num = 0;
 



             reply	other threads:[~2005-08-09 15:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-09 23:43 Vernon Mauery [this message]
2005-08-09 16:15 ` dmi_table counting in ipmi_si_intf.c Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123630997.3246.18.camel@bluecow \
    --to=vernux@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@mvista.com \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.