From: Dave Hansen <haveblue@us.ibm.com>
To: Mike Kravetz <kravetz@us.ibm.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>, Andrew Morton <akpm@osdl.org>,
"Martin J. Bligh" <mbligh@mbligh.org>,
ia64 list <linux-ia64@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH] gurantee DMA area for alloc_bootmem_low() ver. 2.
Date: Wed, 10 Aug 2005 03:06:28 +0000 [thread overview]
Message-ID: <1123643188.7069.8.camel@localhost> (raw)
In-Reply-To: <20050809211501.GB6235@w-mikek2.ibm.com>
On Tue, 2005-08-09 at 14:15 -0700, Mike Kravetz wrote:
> On Tue, Aug 09, 2005 at 08:11:20PM +0900, Yasunori Goto wrote:
> > I modified the patch which guarantees allocation of DMA area
> > at alloc_bootmem_low().
>
> I was going to replace more instances of __pa(MAX_DMA_ADDRESS) with
> max_dma_physaddr(). However, when grepping for MAX_DMA_ADDRESS I
> noticed instances of virt_to_phys(MAX_DMA_ADDRESS) as well. Can
> someone tell me what the differences are between __pa() and virt_to_phys().
At least one is that virt_to_phys()'s argument is usually 'volatile'
while __pa() is not. This, of course, varies from arch to arch.
If somebody wants to go and rip __pa() out from all of the arches, I
won't be especially sorry :)
Actually, it would be nice to have one arch-generic version which is
just the usual (vaddr - PAGE_OFFSET). That would probably take care of
80% of the individual implementations.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Mike Kravetz <kravetz@us.ibm.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>, Andrew Morton <akpm@osdl.org>,
"Martin J. Bligh" <mbligh@mbligh.org>,
ia64 list <linux-ia64@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH] gurantee DMA area for alloc_bootmem_low() ver. 2.
Date: Tue, 09 Aug 2005 20:06:28 -0700 [thread overview]
Message-ID: <1123643188.7069.8.camel@localhost> (raw)
In-Reply-To: <20050809211501.GB6235@w-mikek2.ibm.com>
On Tue, 2005-08-09 at 14:15 -0700, Mike Kravetz wrote:
> On Tue, Aug 09, 2005 at 08:11:20PM +0900, Yasunori Goto wrote:
> > I modified the patch which guarantees allocation of DMA area
> > at alloc_bootmem_low().
>
> I was going to replace more instances of __pa(MAX_DMA_ADDRESS) with
> max_dma_physaddr(). However, when grepping for MAX_DMA_ADDRESS I
> noticed instances of virt_to_phys(MAX_DMA_ADDRESS) as well. Can
> someone tell me what the differences are between __pa() and virt_to_phys().
At least one is that virt_to_phys()'s argument is usually 'volatile'
while __pa() is not. This, of course, varies from arch to arch.
If somebody wants to go and rip __pa() out from all of the arches, I
won't be especially sorry :)
Actually, it would be nice to have one arch-generic version which is
just the usual (vaddr - PAGE_OFFSET). That would probably take care of
80% of the individual implementations.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-08-10 3:06 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 6:50 [PATCH] gurantee DMA area for alloc_bootmem_low() Yasunori Goto
2005-07-12 6:50 ` Yasunori Goto
2005-07-12 14:39 ` Martin J. Bligh
2005-07-12 14:39 ` Martin J. Bligh
2005-07-13 5:09 ` Yasunori Goto
2005-07-13 5:09 ` Yasunori Goto
2005-07-12 18:30 ` Mike Kravetz
2005-07-12 18:30 ` Mike Kravetz
2005-07-12 19:29 ` Dave Hansen
2005-07-12 19:29 ` Dave Hansen
2005-07-12 20:37 ` Mike Kravetz
2005-07-12 20:37 ` Mike Kravetz
2005-07-13 6:34 ` Yasunori Goto
2005-07-13 6:34 ` Yasunori Goto
2005-07-13 22:03 ` Mike Kravetz
2005-07-13 22:03 ` Mike Kravetz
2005-07-15 2:43 ` Yasunori Goto
2005-07-15 2:43 ` Yasunori Goto
2005-08-09 11:11 ` [PATCH] gurantee DMA area for alloc_bootmem_low() ver. 2 Yasunori Goto
2005-08-09 11:11 ` Yasunori Goto
2005-08-09 15:05 ` Martin J. Bligh
2005-08-09 15:05 ` Martin J. Bligh
2005-08-09 21:15 ` Mike Kravetz
2005-08-09 21:15 ` Mike Kravetz
2005-08-10 3:06 ` Dave Hansen [this message]
2005-08-10 3:06 ` Dave Hansen
2005-08-10 16:23 ` Dave Hansen
2005-08-10 16:23 ` Dave Hansen
2005-08-11 20:46 ` Christoph Lameter
2005-08-11 20:46 ` Christoph Lameter
2005-08-11 21:14 ` Mike Kravetz
2005-08-11 21:14 ` Mike Kravetz
2005-08-11 22:37 ` Christoph Lameter
2005-08-11 22:37 ` Christoph Lameter
2005-08-09 23:02 ` Peter Chubb
2005-08-09 23:02 ` Peter Chubb
2005-08-10 6:10 ` Yasunori Goto
2005-08-10 6:10 ` Yasunori Goto
2005-08-18 19:52 ` Andrew Morton
2005-08-18 19:52 ` Andrew Morton
2005-08-18 21:39 ` Andi Kleen
2005-08-18 21:39 ` Andi Kleen
2005-08-19 2:29 ` Yasunori Goto
2005-08-19 2:29 ` Yasunori Goto
2005-08-19 3:03 ` Andi Kleen
2005-08-19 3:03 ` Andi Kleen
2005-08-19 1:26 ` Yasunori Goto
2005-08-19 1:26 ` Yasunori Goto
2005-08-25 9:15 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123643188.7069.8.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=kravetz@us.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.