From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerone Young <jyoung5@us.ibm.com>
Subject: [PATCH] code tidyness xen/tools/symbol.c
Date: Thu, 11 Aug 2005 10:56:42 -0500
Message-ID: <1123775802.3043.16.camel@thinkpad>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Fix where "!" operator used in Bitwise operation. 

In IBM we have an internal source code scanner called BEAM. We have run
it against Xen and here are some of the results.

Signed-off-by: Jerone Young <jyoung5@us.ibm.com>

--- xen/tools/symbols.c.old     2005-08-11 07:42:27.000000000 -0500
+++ xen/tools/symbols.c 2005-08-11 08:06:46.000000000 -0500
@@ -311,7 +311,7 @@ write_src(void)
        off = 0;
        for (i = 0; i < cnt; i++) {

-               if (!table[i].flags & SYM_FLAG_VALID)
+               if (!(table[i].flags & SYM_FLAG_VALID))
                        continue;

                if ((valid & 0xFF) == 0)



-- 
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)