From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerone Young <jyoung5@us.ibm.com>
Subject: Re: code question xen/arch/x86/vmx.c
Date: Thu, 11 Aug 2005 16:57:19 -0500
Message-ID: <1123797440.3043.73.camel@thinkpad>
References: <1123796900.3043.71.camel@thinkpad>
	<c2099c46a3a5d3f4708747b93bbc551e@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <c2099c46a3a5d3f4708747b93bbc551e@cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org


On Thu, 2005-08-11 at 22:47 +0100, Keir Fraser wrote:
> On 11 Aug 2005, at 22:48, Jerone Young wrote:
> 
> > In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer
> > named "reg_p". reg_p is assigned to
> >
> > v->arch.guest_context.debugreg[reg] = *reg_p;
> >
> > in the switch case  TYPE_MOV_TO_DR.
> >
> > yet it has no assignment before this? What is the intent of reg_p?
> >
> > It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it's not
> > used for anything ?
> 
> It's assigned to in the macro CASE_GET_REG_P.

doh! it's sitting right above the function :-)
> 
>   -- Keir
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
-- 
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)