From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ryan Brown <some.nzguy@gmail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
george anzinger <george@mvista.com>
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.13-rc6-V0.7.53-11
Date: Mon, 15 Aug 2005 22:35:28 +0200 [thread overview]
Message-ID: <1124138128.15180.7.camel@twins> (raw)
In-Reply-To: <20050815111804.GA26161@elte.hu>
Hi Ingo,
two small buglets for my config. This is the first .53 kernel that
worked for me (admittedly -07 was the last I tried). It feels a bit odd
but that might be the lack of sleep.
two traces, two patches.
Peter Zijlstra
kernel: WARNING: swapper/1 changed soft IRQ-flags.
kernel: [<c01046b3>] dump_stack+0x23/0x30 (20)
kernel: [<c0147e2f>] illegal_API_call+0x4f/0x60 (20)
kernel: [<c0147f31>] __local_irq_save+0x31/0x40 (8)
kernel: [<c02d4a2e>] rh_call_control+0x16e/0x3e0 (88)
kernel: [<c02d4f53>] rh_urb_enqueue+0x33/0x60 (20)
kernel: [<c02d5c04>] hcd_submit_urb+0x194/0x1c0 (44)
kernel: [<c02d6a01>] usb_submit_urb+0x1e1/0x2c0 (44)
kernel: [<c02d6d1e>] usb_start_wait_urb+0x6e/0x120 (164)
kernel: [<c02d6e69>] usb_internal_control_msg+0x99/0xb0 (32)
kernel: [<c02d6f12>] usb_control_msg+0x92/0xb0 (56)
kernel: [<c02d781a>] usb_get_descriptor+0x9a/0xe0 (76)
kernel: [<c02d7cb5>] usb_get_device_descriptor+0x65/0xa0 (44)
kernel: [<c02d5507>] register_root_hub+0x77/0x160 (44)
kernel: [<c02d63c2>] usb_add_hcd+0x172/0x3b0 (56)
kernel: [<c02dafec>] usb_hcd_pci_probe+0x27c/0x3b0 (56)
kernel: [<c022ea26>] __pci_device_probe+0x56/0x70 (28)
kernel: [<c022ea74>] pci_device_probe+0x34/0x60 (24)
kernel: [<c028156e>] driver_probe_device+0x3e/0xc0 (36)
kernel: [<c02816ef>] __driver_attach+0x4f/0x60 (24)
kernel: [<c0280b12>] bus_for_each_dev+0x62/0x90 (48)
kernel: [<c028172d>] driver_attach+0x2d/0x30 (24)
kernel: [<c0281068>] bus_add_driver+0x88/0xf0 (36)
kernel: [<c0281b4d>] driver_register+0x5d/0x70 (32)
kernel: [<c022ed8a>] pci_register_driver+0x9a/0xc0 (28)
kernel: [<c048c7a9>] ohci_hcd_pci_init+0x39/0x40 (16)
kernel: [<c0471b02>] do_initcalls+0x32/0xf0 (36)
kernel: [<c0471bea>] do_basic_setup+0x2a/0x30 (8)
kernel: [<c01003fa>] init+0x8a/0x290 (24)
kernel: [<c01015f9>] kernel_thread_helper+0x5/0xc (1049518108)
kernel: ---------------------------
kernel: | preempt count: 00000000 ]
kernel: | 0-level deep critical section nesting:
kernel: ----------------------------------------
kernel:
kernel: ------------------------------
kernel: | showing all locks held by: | (swapper/1 [c171b4f0, 116]):
kernel: ------------------------------
kernel:
kernel: #001: [c07f6a74] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #002: [c07f75f4] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #003: [c07f8174] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #004: [c07f8cf4] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #005: [c07f9874] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #006: [c07fa3f4] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #007: [c07faf74] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #008: [c07fbaf4] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #009: [c07fc674] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #010: [c07fd1f4] {(struct semaphore *)(&hwif->gendev_rel_sem)}
kernel: ... acquired at: init_hwif_data+0x94/0x190
kernel:
kernel: #011: [efe6fa00] {(struct semaphore *)(&dev->sem)}
kernel: ... acquired at: __driver_attach+0x21/0x60
kernel:
kernel: #012: [c03dcfe4] {kernel_sem.lock}
kernel: ... acquired at: __reacquire_kernel_lock+0x38/0x80
kernel:
kernel: #013: [c0429144] {usb_bus_list_lock.lock}
kernel: ... acquired at: register_root_hub+0x5b/0x160
--- linux-2.6.13-rc6-git7-RT-V0.7.53-11/drivers/usb/core/hcd.c~ 2005-08-15 21:23:45.000000000 +0200
+++ linux-2.6.13-rc6-git7-RT-V0.7.53-11/drivers/usb/core/hcd.c 2005-08-15 22:03:33.000000000 +0200
@@ -506,13 +506,11 @@ error:
}
/* any errors get returned through the urb completion */
- local_irq_save (flags);
+ local_irq_save_nort (flags);
spin_lock (&urb->lock);
if (urb->status == -EINPROGRESS)
urb->status = status;
spin_unlock (&urb->lock);
usb_hcd_giveback_urb (hcd, urb, NULL);
- local_irq_restore (flags);
+ local_irq_restore_nort (flags);
return 0;
}
kernel: WARNING: softirq-timer/0/4 changed soft IRQ-flags.
kernel: [<c01046b3>] dump_stack+0x23/0x30 (20)
kernel: [<c0147e2f>] illegal_API_call+0x4f/0x60 (20)
kernel: [<c0147f31>] __local_irq_save+0x31/0x40 (8)
kernel: [<c02d4cda>] usb_hcd_poll_rh_status+0x5a/0x180 (48)
kernel: [<c02d4e16>] rh_timer_func+0x16/0x20 (12)
kernel: [<c0131b30>] run_timer_softirq+0x210/0x430 (64)
kernel: [<c012d5af>] ksoftirqd+0xff/0x1f0 (48)
kernel: [<c013f816>] kthread+0xb6/0xf0 (48)
kernel: [<c01015f9>] kernel_thread_helper+0x5/0xc (268668956)
kernel: ---------------------------
kernel: | preempt count: 00000000 ]
kernel: | 0-level deep critical section nesting:
kernel: ----------------------------------------
kernel:
kernel: ------------------------------
kernel: | showing all locks held by: | (softirq-timer/0/4 [effc5510, 98]):
kernel: ------------------------------
kernel:
similar fix, completions need not have irqs disabled on
PREEMPT_RT right?
--- linux-2.6.13-rc6-git7-RT-V0.7.53-11/drivers/usb/core/hcd.c~ 2005-08-15 22:03:33.000000000 +0200
+++ linux-2.6.13-rc6-git7-RT-V0.7.53-11/drivers/usb/core/hcd.c 2005-08-15 22:32:54.000000000 +0200
@@ -538,7 +538,7 @@ void usb_hcd_poll_rh_status(struct usb_h
if (length > 0) {
/* try to complete the status urb */
- local_irq_save (flags);
+ local_irq_save_nort (flags);
spin_lock(&hcd_root_hub_lock);
urb = hcd->status_urb;
if (urb) {
@@ -562,7 +562,7 @@ void usb_hcd_poll_rh_status(struct usb_h
usb_hcd_giveback_urb (hcd, urb, NULL);
else
hcd->poll_pending = 1;
- local_irq_restore (flags);
+ local_irq_restore_nort (flags);
}
/* The USB 2.0 spec says 256 ms. This is close enough and won't
--
Peter Zijlstra <a.p.zijlstra@chello.nl>
next prev parent reply other threads:[~2005-08-15 20:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 11:00 [patch] Real-Time Preemption, -RT-2.6.13-rc4-V0.7.53-01, High Resolution Timers & RCU-tasklist features Ingo Molnar
2005-08-12 3:07 ` Lee Revell
2005-08-12 3:19 ` Lee Revell
2005-08-12 7:03 ` Ingo Molnar
2005-08-12 7:48 ` Thomas Gleixner
2005-08-12 7:07 ` Ingo Molnar
2005-08-13 0:28 ` Ryan Brown
2005-08-13 0:32 ` Lee Revell
2005-08-13 0:57 ` George Anzinger
2005-08-14 2:12 ` Ingo Molnar
2005-08-15 6:29 ` Ingo Molnar
2005-08-15 23:39 ` George Anzinger
2005-08-16 6:36 ` Thomas Gleixner
2005-08-15 11:18 ` [patch] Real-Time Preemption, -RT-2.6.13-rc6-V0.7.53-11 Ingo Molnar
2005-08-15 20:35 ` Peter Zijlstra [this message]
2005-08-16 3:53 ` Ingo Molnar
2005-08-16 14:35 ` Alan Stern
2005-08-16 16:12 ` Ingo Molnar
2005-08-16 16:56 ` Alan Stern
2005-08-16 17:02 ` Ingo Molnar
2005-08-17 2:23 ` David Brownell
2005-08-17 14:10 ` Alan Stern
2005-08-17 20:51 ` David Brownell
2005-08-18 4:52 ` Ingo Molnar
2005-08-18 6:37 ` David Brownell
2005-08-18 14:43 ` Alan Stern
2005-08-22 11:07 ` Ingo Molnar
2005-08-17 6:31 ` Ingo Molnar
2005-08-16 8:41 ` 2.6.13-rc6-rt1 Ingo Molnar
2005-08-16 12:32 ` 2.6.13-rc6-rt1 Michal Schmidt
2005-08-27 1:15 ` 2.6.13-rc6-rt1 Matt Mackall
2005-08-29 22:36 ` 2.6.13-rc6-rt1 Esben Nielsen
2005-08-17 0:53 ` [patch] KGDB for Real-Time Preemption systems George Anzinger
2005-08-17 6:53 ` Ingo Molnar
2005-08-17 19:16 ` George Anzinger
2005-09-05 12:23 ` Serge Noiraud
2005-09-08 0:37 ` George Anzinger
2005-09-07 8:55 ` Serge Noiraud
2005-09-07 21:16 ` George Anzinger
2005-09-08 8:57 ` Serge Noiraud
2005-09-08 20:47 ` George Anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124138128.15180.7.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=some.nzguy@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.