From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: pmac_nvram problems
Date: Thu, 18 Aug 2005 15:00:12 +1000 [thread overview]
Message-ID: <1124341212.8848.78.camel@gaston> (raw)
In-Reply-To: <1124277416.6336.11.camel@localhost>
> I'm not sure why alloc_bootmem is used at all (is the nvram larger than
> a couple of pages on any machine? And if it is, should it really be
> cached in RAM?), but I think it should be sufficient to just use kmalloc
> (well, it works for me).
There used to be cases where we used the nvram stuff before kmalloc()
was available. I'll check if this is still the case.
> Secondly, this driver misses power management. Having suspended, I
> booted OSX which always resets the boot volume. But after resuming
> linux, nvsetvol(8) still reports 0 as the boot volume because the
> pmac_nvram driver caches the nvram contents. Fixing this would require
> converting the driver to the new model though, I think.
Well... the driver doesn't expect you to boot a different OS while
suspended to disk :)
Regarding caching the data in memory, this is done becaues nvram is
actually a flash on recent machines, and you really want to limit the
number of write cycles to it.
Ben.
next prev parent reply other threads:[~2005-08-18 5:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-17 11:16 pmac_nvram problems Johannes Berg
2005-08-18 5:00 ` Benjamin Herrenschmidt [this message]
2005-08-18 13:03 ` Johannes Berg
2005-08-18 21:40 ` Benjamin Herrenschmidt
2005-08-19 10:55 ` Johannes Berg
2005-08-20 0:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124341212.8848.78.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.