All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@cyclades.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@zip.com.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] swsusp: fix error handling and cleanups
Date: Tue, 23 Aug 2005 09:35:21 +1000	[thread overview]
Message-ID: <1124753721.5093.11.camel@localhost> (raw)
In-Reply-To: <20050822090047.GA8841@elf.ucw.cz>

Hi.

On Mon, 2005-08-22 at 19:00, Pavel Machek wrote:
> @@ -1207,7 +1208,6 @@ static int check_sig(void)
>  		 */
>  		error = bio_write_page(0, &swsusp_header);
>  	} else { 
> -		printk(KERN_ERR "swsusp: Suspend partition has wrong signature?\n");
>  		return -EINVAL;
>  	}

This is an especially good change - I've seen some bogus displays of
this message but haven't looked into why, sorry.

Regards,

Nigel

-- 
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.


      reply	other threads:[~2005-08-22 23:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-22  9:00 [patch] swsusp: fix error handling and cleanups Pavel Machek
2005-08-22 23:35 ` Nigel Cunningham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1124753721.5093.11.camel@localhost \
    --to=ncunningham@cyclades.com \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.