All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] Bluetooth SCO message sending (sco_send_frame)
Date: Tue, 23 Aug 2005 15:52:48 +0200	[thread overview]
Message-ID: <1124805168.23599.164.camel@pegasus> (raw)
In-Reply-To: <430B28C7.8000406@core.kaist.ac.kr>

Hi Youngwoo,

> When the SCO message size is larger than MTU, sco_send_fram function is
> just returned
> and sco message is not sent.
> 
> For that reason, I can't use bluetooth sound application using SCO
> channel through h4 interface.
> (Of course, I adjusted the MTU size more larger but failed to hear
> bluetooth sound.)
> 
> I fixed it to divide bluetooth message along with the MTU size and send
> more message..
> Although it is not perfect, it operate well..
> 
> My patch is below..

the problem is that your patch is unreadable. Follow the coding style
and only diff the needed changes.

Regards

Marcel




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2005-08-23 13:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-23 13:46 [Bluez-devel] Bluetooth SCO message sending (sco_send_frame) Youngwoo Park
2005-08-23 13:52 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1124805168.23599.164.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.