From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andi Kleen <ak@suse.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Fix crash in aic79xx probing in scsi-misc when no hardware is present
Date: Wed, 31 Aug 2005 08:29:08 -0500 [thread overview]
Message-ID: <1125494948.4807.16.camel@mulgrave> (raw)
In-Reply-To: <200508311045.54846.ak@suse.de>
On Wed, 2005-08-31 at 10:45 +0200, Andi Kleen wrote:
> aic79xx in scsi-misc would oops when no hardware was present.
> Reason was a duplicated call to free the spi transport object -
> it was done both in ahd_linux_exit and in the cleanup part
> of ahd_linux_init.
>
> Just remove the superfluous call.
Actually, the fix is slightly wrong. The correct thing to do is remove
ahd_linux_exit() (It really does nothing in the failure case except
release the transport) which is an __exit function.
The one I plan to push is here:
http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=a80b3424d9fde3c4b6d62adaf6dda78128dc5c27
James
prev parent reply other threads:[~2005-08-31 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 8:45 [PATCH] Fix crash in aic79xx probing in scsi-misc when no hardware is present Andi Kleen
2005-08-31 13:29 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125494948.4807.16.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=ak@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.