From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Russell King <rmk@arm.linux.org.uk>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH 1/1] 8250_kgdb driver reworked
Date: Thu, 01 Sep 2005 22:57:54 +0100 [thread overview]
Message-ID: <1125611874.15768.79.camel@localhost.localdomain> (raw)
In-Reply-To: <20050901190251.GS3966@smtp.west.cox.net>
> +static irqreturn_t
> +kgdb8250_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> +{
> + char iir;
> +
> + if (irq != KGDB8250_IRQ)
> + return IRQ_NONE;
How can this occur - you gave the IRQ number in the register_irq. WHy
test for it, and if it occurs why not BUG()
> + /*
> + * If there is some other CPU in KGDB then this is a
> + * spurious interrupt. so return without even checking a byte
> + */
> + if (atomic_read(&debugger_active))
> + return IRQ_NONE;
> +
Shared IRQ -> hung box.
Also lose the ugly confusing macros like CURRENTPORT please to follow
kernel style better. In fact why not keep a pointer to the 'current'
uart to get tighter code too ?
next prev parent reply other threads:[~2005-09-01 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 19:02 [PATCH 1/1] 8250_kgdb driver reworked Tom Rini
2005-09-01 19:55 ` Andrew Morton
2005-09-01 21:57 ` Alan Cox [this message]
2005-09-01 21:47 ` Tom Rini
2005-09-01 22:44 ` Alan Cox
2005-09-01 22:45 ` Tom Rini
2005-09-01 23:36 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125611874.15768.79.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.