From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andreas Herrmann <aherrman@de.ibm.com>
Cc: Linux SCSI <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler
Date: Sat, 03 Sep 2005 09:45:01 -0400 [thread overview]
Message-ID: <1125755101.4803.5.camel@mulgrave> (raw)
In-Reply-To: <20050903123042.GA7902@lion28.boeblingen.de.ibm.com>
On Sat, 2005-09-03 at 14:30 +0200, Andreas Herrmann wrote:
> zfcp: introduce eh_timed_out handler
>
> This handler is required to avoid offlined SCSI devices in a multipath
> setup if scsi commands time out on cable pulls lasting longer than 30
> seconds.
But that's not what the patch does. It short circuits the error handler
globally, not just in the cable pulled case.
For any error induced timeout, you're going to follow this logic. In
particular, if the device itself actually has an issue and genuinely
needs to be reset, that's never going to happen.
Is this really what you want to do?
James
next prev parent reply other threads:[~2005-09-03 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-03 12:30 [PATCH 1/7] zfcp: introduce eh_timed_out handler Andreas Herrmann
2005-09-03 12:56 ` Arjan van de Ven
2005-09-03 13:45 ` James Bottomley [this message]
2005-09-03 14:53 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2005-09-03 13:21 Andreas Herrmann
2005-09-04 10:34 Andreas Herrmann
2005-09-04 10:37 Andreas Herrmann
2005-09-04 10:49 Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125755101.4803.5.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=aherrman@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.