From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] get xenstore buffer in vmx guest
Date: Mon, 05 Sep 2005 21:14:53 +1000
Message-ID: <1125918893.6348.4.camel@localhost.localdomain>
References: <431C03FC.1060302@intel.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <431C03FC.1060302@intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Xiaofeng Ling <xiaofeng.ling@intel.com>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2005-09-05 at 16:38 +0800, Xiaofeng Ling wrote:
>   static inline struct ringbuf_head *outbuf(void)
>   {
> -	return mfn_to_virt(xen_start_info.store_mfn);
> +	return XENSTORE_BUF;
>   }

Just a minor thing: I'd really prefer an inline function called
xenstore_page_virt() or something, rather than a macro which looks like
a constant.

Thanks!
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman