From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: RE: [PATCH] get xenstore buffer in vmx guest
Date: Tue, 06 Sep 2005 10:15:54 +1000
Message-ID: <1125965755.7643.35.camel@localhost.localdomain>
References: <3ACA40606221794F80A5670F0AF15F84095B7041@pdsmsx403>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <3ACA40606221794F80A5670F0AF15F84095B7041@pdsmsx403>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Ling, Xiaofeng" <xiaofeng.ling@intel.com>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2005-09-05 at 22:22 +0800, Ling, Xiaofeng wrote:
> Rusty Russell <mailto:rusty@rustcorp.com.au> wrote:
> > Just a minor thing: I'd really prefer an inline function called
> > xenstore_page_virt() or something, rather than a macro which looks
> > like a constant. 
> ok, so the new patch will be:

> --- a/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_comms.h    Tue Aug 30 20:36:49 2005
> +++ b/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_comms.h    Mon Sep  5 22:15:45 2005
> @@ -38,4 +38,17 @@
>  int xs_input_avail(void);
>  extern wait_queue_head_t xb_waitq;
> 
> +#ifdef CONFIG_XEN
> +static inline void *xenstore_page_virt(void)
> +{
> +    return (void*)mfn_to_virt(xen_start_info.store_mfn);
> +}

Great!   I think the (void*) cast is redundant though?

> -postcore_initcall(xenbus_probe_init);
> +module_init(xenbus_probe_init);
> +MODULE_LICENSE("GPL");

This should probably be:
	MODULE_LICENSE("Dual BSD/GPL");

Cheers,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman