From: Lee Revell <rlrevell@joe-job.com>
To: Rumen Ivanov Zarev <rzarev@its.caltech.edu>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Unhide SMBus on Compaq Evo N620c
Date: Tue, 06 Sep 2005 18:43:10 -0400 [thread overview]
Message-ID: <1126046590.13159.9.camel@mindpipe> (raw)
In-Reply-To: <200509062039.j86KdWMr014934@inky.its.caltech.edu>
On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
> Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
> Intel 82855PM chipset.
> + } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {
Should unlikely() be used for cases where the conditional will be true
iff a specific piece of hardware is present? Seems like we'd always
lose.
Lee
next prev parent reply other threads:[~2005-09-06 22:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 20:39 [PATCH] PCI: Unhide SMBus on Compaq Evo N620c Rumen Ivanov Zarev
2005-09-06 22:43 ` Lee Revell [this message]
2005-09-06 22:59 ` Rumen Zarev
2005-09-06 23:01 ` Dmitry Torokhov
2005-09-07 18:12 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126046590.13159.9.camel@mindpipe \
--to=rlrevell@joe-job.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rzarev@its.caltech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.