From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] [PATCH] Fix infinite loops in textfile.c
Date: Sat, 10 Sep 2005 11:43:41 +0200 [thread overview]
Message-ID: <1126345421.5697.5.camel@blade> (raw)
In-Reply-To: <4321BDC2.70404@tcs.hut.fi>
Hi Ville,
> both textfile_put() and textfile_get() go into inifinite loops if a
> string matching the search key is found anywhere except at the beginning
> of a line.
>
> Both functions may also get false positive matches if the search key
> forms a substring of some other key in the same file.
>
> The attached patch fixes both problems, but I can split it up into two
> separate parts if you wish.
no need to split it. Thanks for the patch. I applied it.
What do you think about writing some regression tests for the textfile
library?
Regards
Marcel
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
prev parent reply other threads:[~2005-09-10 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 16:52 [Bluez-devel] [PATCH] Fix infinite loops in textfile.c Ville Nuorvala
2005-09-10 9:43 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126345421.5697.5.camel@blade \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.