From: Paolo Bonzini <pbonzini@redhat.com>
To: Isaku Yamahata <yamahata@private.email.ne.jp>
Cc: owasserm@redhat.com, mrhines@us.ibm.com, qemu-devel@nongnu.org,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len
Date: Wed, 7 Aug 2013 03:40:28 -0400 (EDT) [thread overview]
Message-ID: <1126524175.10530041.1375861228957.JavaMail.root@redhat.com> (raw)
In-Reply-To: <cover.1375842339.git.yamahata@private.email.ne.jp>
> RDMAControlHeader::len is remote-provided. So validate the value before use.
>
> Isaku Yamahata (3):
> rdma: use resp.len after validation in qemu_rdma_registration_stop
> rdma: validate RDMAControlHeader::len
> rdma: check if RDMAControlHeader::len match transferred byte
>
> migration-rdma.c | 44 ++++++++++++++++++++++++++++++--------------
> 1 file changed, 30 insertions(+), 14 deletions(-)
Looks good, thanks!
We will have a mix of assertions and errors after this patch.
Asserting on the destination is probably okay, but as a follow-up
perhaps we can change the assertion(s) to errors.
Paolo
next prev parent reply other threads:[~2013-08-07 7:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 2:26 [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len Isaku Yamahata
2013-08-07 2:26 ` [Qemu-devel] [PATCH 1/3] rdma: use resp.len after validation in qemu_rdma_registration_stop Isaku Yamahata
2013-08-07 2:26 ` [Qemu-devel] [PATCH 2/3] rdma: validate RDMAControlHeader::len Isaku Yamahata
2013-08-07 2:26 ` [Qemu-devel] [PATCH 3/3] rdma: check if RDMAControlHeader::len match transferred byte Isaku Yamahata
2013-08-07 7:40 ` Paolo Bonzini [this message]
2013-08-07 8:54 ` [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len Orit Wasserman
2013-08-07 15:02 ` Michael R. Hines
2013-08-14 16:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126524175.10530041.1375861228957.JavaMail.root@redhat.com \
--to=pbonzini@redhat.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yamahata@private.email.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.