From: Jerone Young <jyoung5@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] fix "make uninstall" so that it will remove files first
Date: Sat, 24 Sep 2005 00:57:21 -0500 [thread overview]
Message-ID: <1127541441.17811.4.camel@thinkpad> (raw)
If anyone knows a better way to check for a file in make please reply to
this patch. The problem here is that when /etc/xen does not exist "[ -d
$(D)/etc/xen ]" (otherwise know as "test") return 1 and make bails out.
So I have moved this as the last task as a temporary fix.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
# HG changeset patch
# User root@leaf9.ltc.austin.ibm.com
# Node ID 18994ae7c234f71d8ef994dcd12c6dcf1a748c42
# Parent 2f83ff9f6bd2a7987c297b84bfce1f8e22409cae
Change so that test for existance of /etc/xen is last. If the test fails
then the entire uninstall process fails and no file are removed.
diff -r 2f83ff9f6bd2 -r 18994ae7c234 Makefile
--- a/Makefile Thu Sep 22 17:03:16 2005
+++ b/Makefile Sat Sep 24 04:54:03 2005
@@ -164,7 +164,6 @@
uninstall: DESTDIR=
uninstall: D=$(DESTDIR)
uninstall:
- [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-`date
+%s`
rm -rf $(D)/etc/init.d/xend*
rm -rf $(D)/etc/hotplug/xen-backend.agent
rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
@@ -185,6 +184,7 @@
rm -rf $(D)/usr/share/xen
rm -rf $(D)/usr/share/man/man1/xen*
rm -rf $(D)/usr/share/man/man8/xen*
+ [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-`date
+%s`
# Legacy targets for compatibility
linux24:
--
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)
next reply other threads:[~2005-09-24 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-24 5:57 Jerone Young [this message]
2005-09-24 7:41 ` [PATCH] fix "make uninstall" so that it will remove files first Keir Fraser
2005-09-25 9:12 ` Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127541441.17811.4.camel@thinkpad \
--to=jyoung5@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.