All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jake Maciejewski <maciejej@msoe.edu>
To: Alexander Zarochentsev <zam@namesys.com>
Cc: reiserfs-list@namesys.com,
	"Łukasz Mierzwa" <prymitive@pcserwis.hopto.org>,
	"Hans Reiser" <reiser@namesys.com>
Subject: Re: reiser4 for 2.6.13 is available on our website
Date: Sat, 01 Oct 2005 02:20:38 -0500	[thread overview]
Message-ID: <1128151238.9989.18.camel@gentoo> (raw)
In-Reply-To: <200509301231.02169.zam@namesys.com>

It compiles and boots, but I can't stress test because two of my NICs
don't work in 2.6.13.

I don't know which patch(es) fixed my NIC problem, but I recall
2.6.14-rc1 working. When I tried the 2.6.13-1 patch against rc1, I got a
failed hunk in lib/radix-tree.c which I attempted to fix manually. It
compiled, but I got a panic starting init.

On Fri, 2005-09-30 at 12:31 +0400, Alexander Zarochentsev wrote:
> On Friday 30 September 2005 02:09, Jake Maciejewski wrote:
> > I get the same with 2.6.13.2 and gcc 3.4.4 on amd64
> >
> can you try this patch?
> -----------------------------------
> --- a/fs/reiser4/spin_macros.h
> +++ b/fs/reiser4/spin_macros.h
> @@ -82,8 +82,6 @@ typedef struct reiser4_rw_data {
>  static inline void spin_ ## NAME ## _init(TYPE *x)				\
>  {										\
>  	__ODCA("nikita-2987", x != NULL);					\
> -	cassert(sizeof(x->FIELD) != 0);						\
> -	memset(& x->FIELD, 0, sizeof x->FIELD);					\
>  	spin_lock_init(& x->FIELD.lock);					\
>  }										\
>  										\
> @@ -236,7 +234,6 @@ typedef struct { int foo; } NAME ## _spi
>  static inline void rw_ ## NAME ## _init(TYPE *x)				\
>  {										\
>  	__ODCA("nikita-2988", x != NULL);					\
> -	memset(& x->FIELD, 0, sizeof x->FIELD);					\
>  	rwlock_init(& x->FIELD.lock);						\
>  }										\
>  										\
> -----------------------------------
> > On Thu, 2005-09-29 at 20:24 +0200, £ukasz Mierzwa wrote:
> > > Dnia Thu, 29 Sep 2005 19:25:54 +0200, Hans Reiser <reiser@namesys.com>
> > >
> > > napisa³:
> > > > Reiser4 performance dropped in the -mm series due to the write
> > > > throttling patch and also dropped due to a fixed bug (removing type
> > > > safe lists added a bug).  We don't yet know if we got quite all the
> > > > performance back, we are still testing.  Conservative users should wait
> > > > a week or two to see if bug reports with reiser4 remain, or if indeed
> > > > we did get all the bugs out  of the recent cleanup patch.
> > > >
> > > > Hans
> > >
> > >    CC      fs/proc/kmsg.o
> > >    CC      fs/proc/proc_tty.o
> > >    CC      fs/proc/proc_misc.o
> > >    CC      fs/proc/kcore.o
> > >    LD      fs/proc/proc.o
> > >    LD      fs/proc/built-in.o
> > >    CC      fs/ramfs/inode.o
> > >    LD      fs/ramfs/ramfs.o
> > >    LD      fs/ramfs/built-in.o
> > >    CC      fs/reiser4/debug.o
> > > In file included from fs/reiser4/lock.h:15,
> > >                   from fs/reiser4/context.h:14,
> > >                   from fs/reiser4/debug.c:25:
> > > fs/reiser4/txnmgr.h: In function 'spin_atom_init':
> > > fs/reiser4/txnmgr.h:512: error: duplicate case value
> > > fs/reiser4/txnmgr.h:512: error: previously used here
> > > fs/reiser4/txnmgr.h: In function 'spin_txnh_init':
> > > fs/reiser4/txnmgr.h:513: error: duplicate case value
> > > fs/reiser4/txnmgr.h:513: error: previously used here
> > > fs/reiser4/txnmgr.h: In function 'spin_txnmgr_init':
> > > fs/reiser4/txnmgr.h:514: error: duplicate case value
> > > fs/reiser4/txnmgr.h:514: error: previously used here
> > > In file included from fs/reiser4/context.h:14,
> > >                   from fs/reiser4/debug.c:25:
> > > fs/reiser4/lock.h: In function 'spin_stack_init':
> > > fs/reiser4/lock.h:198: error: duplicate case value
> > > fs/reiser4/lock.h:198: error: previously used here
> > > In file included from fs/reiser4/znode.h:16,
> > >                   from fs/reiser4/tree.h:15,
> > >                   from fs/reiser4/super.h:9,
> > >                   from fs/reiser4/debug.c:26:
> > > fs/reiser4/jnode.h: In function 'spin_jnode_init':
> > > fs/reiser4/jnode.h:344: error: duplicate case value
> > > fs/reiser4/jnode.h:344: error: previously used here
> > > fs/reiser4/jnode.h: In function 'spin_jload_init':
> > > fs/reiser4/jnode.h:348: error: duplicate case value
> > > fs/reiser4/jnode.h:348: error: previously used here
> > > In file included from fs/reiser4/super.h:9,
> > >                   from fs/reiser4/debug.c:26:
> > > fs/reiser4/tree.h: In function 'spin_epoch_init':
> > > fs/reiser4/tree.h:169: error: duplicate case value
> > > fs/reiser4/tree.h:169: error: previously used here
> > > In file included from fs/reiser4/debug.c:26:
> > > fs/reiser4/super.h: In function 'spin_super_init':
> > > fs/reiser4/super.h:379: error: duplicate case value
> > > fs/reiser4/super.h:379: error: previously used here
> > > make[2]: *** [fs/reiser4/debug.o] B³±d 1
> > > make[1]: *** [fs/reiser4] B³±d 2
> > > make: *** [fs] B³±d 2
> > >
> > > amd64 gentoo box running gcc 4.0.1, 2.6.13 +
> > > reiser4-for-2.6.13-1.patch.gz
-- 
Jake Maciejewski <maciejej@msoe.edu>


      parent reply	other threads:[~2005-10-01  7:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-29 17:25 reiser4 for 2.6.13 is available on our website Hans Reiser
2005-09-29 18:24 ` Łukasz Mierzwa
2005-09-29 22:09   ` Jake Maciejewski
2005-09-29 22:32     ` Hans Reiser
2005-09-29 23:23       ` Gregory Maxwell
2005-09-30  2:59         ` Dan Oglesby
2005-09-30  3:03           ` Dan Oglesby
2005-09-30  5:02             ` Dan Oglesby
2005-09-30  6:01               ` Dan Oglesby
2005-09-30  8:31     ` Alexander Zarochentsev
2005-09-30 12:01       ` Łukasz Mierzwa
2005-10-01  7:20       ` Jake Maciejewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1128151238.9989.18.camel@gentoo \
    --to=maciejej@msoe.edu \
    --cc=prymitive@pcserwis.hopto.org \
    --cc=reiser@namesys.com \
    --cc=reiserfs-list@namesys.com \
    --cc=zam@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.