From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "linux-os (Dick Johnson)" <linux-os@analogic.com>
Cc: Mark Hounschell <markh@compro.net>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: Opterons and setting the pci bus master bit
Date: Sun, 02 Oct 2005 18:54:54 +1000 [thread overview]
Message-ID: <1128243294.8267.48.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.61.0509301318370.31041@chaos.analogic.com>
On Fri, 2005-09-30 at 13:32 -0400, linux-os (Dick Johnson) wrote:
> pci_set_dma_mask(dev, 0xffffffffULL); // 32 bit DMA only
> pci_set_drvdata(dev, NULL); // Harmless if unused
> pci_set_power_state(dev, 0); // Turn it ON
> pci_set_master(dev); // Make bus-master
> pci_set_mwi(dev); // Check return, different code
> pci_write_config_dword(dev, PCI_COMMAND, PCI_CONFIG_YOU_DEFINE);
>
> Typical bus-master PCI_CONFIG_YOU_DEFINE is:
> (PCI_COMMAND_MEMORY|PCI_COMMAND_MASTER|PCI_COMMAND_SERR)
Actually the last one is slightly bogus for things like
memory/master/etc... you shouldn't bother about these if you do things
correctly and call ... pci_enable_device() which you forgot :)
Ben.
next prev parent reply other threads:[~2005-10-02 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 17:10 Opterons and setting the pci bus master bit Mark Hounschell
2005-09-30 17:32 ` linux-os (Dick Johnson)
2005-10-02 8:54 ` Benjamin Herrenschmidt [this message]
2005-09-30 18:19 ` Alan Cox
2005-09-30 18:29 ` Mark Hounschell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128243294.8267.48.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.