From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-kernel@vger.kernel.org, info-linux@ldcmail.amd.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/7] AMD Geode GX/LX support
Date: Mon, 03 Oct 2005 20:06:32 +0100 [thread overview]
Message-ID: <1128366392.26992.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20051003175851.GG29264@cosmic.amd.com>
On Llu, 2005-10-03 at 11:58 -0600, Jordan Crouse wrote:
> +
> + hwif->udma_four = w80; /* w80 = 1 if a 80 conductor line is attached */
> +
> + if (hwif->mate)
> + hwif->serialized = hwif->mate->serialized = 1;
Is this needed, it doesn't seem to be in the databook or errata ?
> Index: linux-2.6.14-rc2-mm2/drivers/ide/pci/cs5535.h
> ===================================================================
> --- /dev/null
> +++ linux-2.6.14-rc2-mm2/drivers/ide/pci/cs5535.h
> @@ -0,0 +1,72 @@
Please put the private structure into the .c file as the other code now
does. Its a tidy up that wants picking up.
next prev parent reply other threads:[~2005-10-03 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-03 17:58 [PATCH 5/7] AMD Geode GX/LX support Jordan Crouse
2005-10-03 19:06 ` Alan Cox [this message]
2005-10-03 19:34 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128366392.26992.33.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=info-linux@ldcmail.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.