From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerone Young Subject: Re: [PATCH] Fix tools makefile to properly check for external tools Date: Tue, 04 Oct 2005 14:04:41 -0500 Message-ID: <1128452681.15111.14.camel@thinkpad> References: <1128451606.15111.10.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1128451606.15111.10.camel@thinkpad> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel List-Id: xen-devel@lists.xenproject.org Ok ,thinking about the comment in tools/check/Makefile is so that one could install stuff in "dist" directory. But our networking scripts have no checks at all to see if (for example) "brctl" is even there...it just silently installs. So given this when would one check that we have everything need installed. Also I will submit a patch to add a check to the network script to see if the tools are actually on the system. On Tue, 2005-10-04 at 13:46 -0500, Jerone Young wrote: > Signed-off-by: Jerone Young > > Fix tools makefile so that extrnal tools checks are run to ensure > extrnal tools are actually installed. > > diff -r 00037ba13f0b -r cc75d51355cb tools/Makefile > --- a/tools/Makefile Tue Oct 4 17:23:58 2005 > +++ b/tools/Makefile Tue Oct 4 16:28:18 2005 > @@ -33,7 +33,7 @@ > done > $(MAKE) ioemu > > -install: check > +install: check_install > @set -e; for subdir in $(SUBDIRS); do \ > $(MAKE) -C $$subdir $@; \ > done > @@ -48,6 +48,9 @@ > check: > $(MAKE) -C check > > +check_install: > + $(MAKE) -C check install > + > check_clean: > $(MAKE) -C check clean > > -- Jerone Young IBM Linux Technology Center jyoung5@us.ibm.com 512-838-1157 (T/L: 678-1157)