From: Rusty Russell <rusty@rustcorp.com.au>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: Jimi Xenidis <jimix@watson.ibm.com>, xen-devel@lists.xensource.com
Subject: Re: My turn to rant about types... bitops
Date: Mon, 10 Oct 2005 21:44:07 +1000 [thread overview]
Message-ID: <1128944647.5611.79.camel@localhost.localdomain> (raw)
In-Reply-To: <9b50cd44c3f828463b6fa01170382dd4@cl.cam.ac.uk>
On Wed, 2005-10-05 at 19:17 +0100, Keir Fraser wrote:
> On 5 Oct 2005, at 17:52, Jimi Xenidis wrote:
>
> > I think around linux-2.4.19 (and thanks to rusty?) bitops.h went
> > s/void */unsigned long */, any chance is Xen following suit?
> > The next request would be to change all arrays destined for bitops to
> > be defined using unsigned long.
> > specifically:
>
> Just cast to 'unsigned long *' when you use those ops. Why work around
> details of the way that Linux happens to do atomic ops in our
> interfaces?
A bitmask type might be nice. Linux has some ugly macros to do just
that, but at least it's explicit ("need this many bits").
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
prev parent reply other threads:[~2005-10-10 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 16:52 My turn to rant about types... bitops Jimi Xenidis
2005-10-05 18:17 ` Keir Fraser
2005-10-06 11:32 ` Jimi Xenidis
2005-10-06 13:39 ` Andi Kleen
2005-10-06 15:10 ` Jimi Xenidis
2005-10-06 15:19 ` Andi Kleen
[not found] ` <7D88E873-B404-4E28-BE87-D474F67CAA82@watson.ibm.com>
2005-10-06 12:49 ` Keir Fraser
2005-10-10 11:44 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128944647.5611.79.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=jimix@watson.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.