Re: [Bluez-devel] hcid patch (patch 00.13)

[Marcel Holtmann <marcel@holtmann.org>]

Hi Johan,

> > I applied the patch, but this can't be the final solution. It will
> > produce weird stuff on 64-bit machines:
> 
> Yeah, I suspected that could cause problems since
> sizeof(int) != sizeof(void *) on those machines. I don't think those
> compiler warnings are dangerous though, since they are probably meant to
> warn about possible loss of data which shouldn't happen to us since our
> values always fit within 2 bytes. I don't have a 64bit machine so I
> can't verify this fix, but I think that sizeof(long) should be the same
> as sizeof(void *) on both 32 and 64 bit machines. If that isn't the
> case, the last resort could be to make some automake makro to check the
> actual size of pointer types and add #defines to the code acordingly.
> 
> Anyway, the attached patch uses long for the pointer<->integer
> typecasts. Let me know if it doesn't work.

I applied your patch and the compiler on my 64-bit machine is much
happier now, but I think that we need to allocate a structure and pass
the pointer to it around instead of some casting tricks. Would you mind
fixing it?

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel