Re: [PATCH nfsim] tcpsession: implement the RESET command

[Rusty Russell <rusty@rustcorp.com.au>]

On Mon, 2005-10-10 at 15:14 +0200, Max Kellermann wrote:
> On 2005/10/10 15:03, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > > That assumes that nfsim provides the extensions, or that extensions
> > > have to be installed in one of those paths.  IMHO, the extensions may
> > > be shipped along with a test.  e.g. my h323 tests ship their own
> > > tools.  To make testing easy, it should be possible to use extensions
> > > without installing them (i.e. without root access?).
> > 
> > I assumed you would want to merge your tests into nfsim-testsuite...
> 
> I do want that.  But there is a reason nfsim-testsuite is separate
> from nfsim itself, and the extensions (like my generate-h225-packet
> tool) are co-developed with the tests using it, not with nfsim itself.

Sure, but if they are generic enough they belong in nfsim, I think.
nfsim is more than the basis for the testsuite: it also allows people to
test their particular configurations.  So I would argue that your tools
belong in nfsim.

> > OK, how about this:
> > (1) Use $NFSIM_EXTPATH if set, else
> > (1) Use ".:tools/extensions:$PATH" if we're in the nfsim dir, else
> > (2) Use ".:/usr/lib/nfsim/extensions:$PATH" if we're not.
> 
> Why don't you add all of them to $PATH (if set and present)?  I
> believe the following order would be best:
> 
>  1. "." (or better `dirname $testfile.sim`)
>  2. $NFSIM_EXTPATH
>  3. $srcdir/tools/extensions
>  4. $pkglibdir
> 
> It is perfectly possible for a test suite to use extensions included
> in nfsim _and_ extensions the test suite itself shipped.

No.  NFSIM_EXTPATH should override: the user can create the above logic
if they want.  I certainly don't want to run random programs which
happen to be in the path.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman