From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [Bluez-devel] hcid patch (remote name and connections) From: Marcel Holtmann To: bluez-devel@lists.sourceforge.net In-Reply-To: <20051011195531.GA12935@localhost.localdomain> References: <1129053693.8229.1.camel@localhost.localdomain> <20051011192801.GA12571@localhost.localdomain> <434C164E.5090805@csr.com> <20051011195531.GA12935@localhost.localdomain> Content-Type: text/plain Message-Id: <1129070919.6487.4.camel@localhost.localdomain> Mime-Version: 1.0 Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 12 Oct 2005 00:48:38 +0200 Hi Johan, > > I'd recommend encapsulating the id in a structure rather than allocating > > sizeof(guint). It doesn't cost you much time now and if, in the future, > > you ever need to store any more information then the structure's already > > there. > > I noticed you already have a structure struct hci_dbus_data which > > contains just an integer. Did you mean to use that here or are they > > logically separate types (that just happen to be the same at the > > moment)? > > The watch code is logically completely separate from the code that uses > the hci_dbus_data struct (the "id" variable refers to a GIOChannel id > while in the hci_dbus_data struct id refers to the device id). It is > also much simpler than the code that uses hci_dbus_data and I don't > think that anything besides the GIOChannel id needs to be passed to the > remove_watch function. the patch is in and I agree with you that it makes no sense to take care of this issue, because we will no longer use GIOChannel in bluetoothd in the future. Regards Marcel ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel