From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755726AbcBIQoq (ORCPT ); Tue, 9 Feb 2016 11:44:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35238 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755006AbcBIQoo (ORCPT ); Tue, 9 Feb 2016 11:44:44 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1454584165-9547-1-git-send-email-juerg.haefliger@hpe.com> References: <1454584165-9547-1-git-send-email-juerg.haefliger@hpe.com> <1454145497-4567-1-git-send-email-juerg.haefliger@hpe.com> To: Juerg Haefliger Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, dwmw2@infradead.org Subject: Re: [PATCH v2] scripts/sign-file.c: Add support for signing with a raw signature MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11290.1455036282.1@warthog.procyon.org.uk> Date: Tue, 09 Feb 2016 16:44:42 +0000 Message-ID: <11291.1455036282@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Juerg Haefliger wrote: > This patch adds support for signing a kernel module with a raw > detached PKCS#7 signature/message. > > The signature is not converted and is simply appended to the module so > it needs to be in the right format. Using openssl, a valid signature can > be generated like this: > $ openssl smime -sign -nocerts -noattr -binary -in -inkey \ > -signer -outform der -out > > The resulting raw signature from the above command is (more or less) > identical to the raw signature that sign-file itself can produce like > this: > $ scripts/sign-file -d > > Signed-off-by: Juerg Haefliger Looks okay. I'll apply it unless David Woodhouse has an objection. David