diff for duplicates of <1129266725.22903.25.camel@localhost> diff --git a/a/1.txt b/N1/1.txt index 9da4622..9686c57 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -52,12 +52,13 @@ commonality to use it? > + if (vma->vm_pgoff != 0) > + return -EINVAL; > + -> + if ((vma->vm_flags & VM_WRITE) = 0) +> + if ((vma->vm_flags & VM_WRITE) == 0) > + return -EPERM; > + > + pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + if (! -> + (vdata > + vmalloc(sizeof(struct vma_data) + pages * sizeof(long)))) +> + (vdata = +> + vmalloc(sizeof(struct vma_data) + pages * sizeof(long)))) > + return -ENOMEM; How about: diff --git a/a/content_digest b/N1/content_digest index 9000a9f..2e73143 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020051012194233.GG17458@lnx-holt.americas.sgi.com\0" "From\0Dave Hansen <haveblue@us.ibm.com>\0" "Subject\0Re: [Patch 2/2] Special Memory (mspec) driver.\0" - "Date\0Fri, 14 Oct 2005 05:12:05 +0000\0" + "Date\0Thu, 13 Oct 2005 22:12:05 -0700\0" "To\0Robin Holt <holt@sgi.com>\0" "Cc\0ia64 list <linux-ia64@vger.kernel.org>" linux-mm <linux-mm@kvack.org> @@ -66,12 +66,13 @@ "> +\tif (vma->vm_pgoff != 0)\n" "> +\t\treturn -EINVAL;\n" "> +\n" - "> +\tif ((vma->vm_flags & VM_WRITE) = 0)\n" + "> +\tif ((vma->vm_flags & VM_WRITE) == 0)\n" "> +\t\treturn -EPERM;\n" "> +\n" "> +\tpages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;\n" "> +\tif (!\n" - "> +\t (vdata > +\t vmalloc(sizeof(struct vma_data) + pages * sizeof(long))))\n" + "> +\t (vdata =\n" + "> +\t vmalloc(sizeof(struct vma_data) + pages * sizeof(long))))\n" "> +\t\treturn -ENOMEM;\n" "\n" "How about:\n" @@ -114,4 +115,4 @@ "\n" -- Dave -c7be92a35abb59c47d9a6b38de9ace6696b955b87e76d29432b045d71ce2a1e1 +f4bd839c4d075855bbabaf3c88c527821b1939bf9cbd5d0170d97ee58c81e358
diff --git a/a/1.txt b/N2/1.txt index 9da4622..4565ad8 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -52,12 +52,13 @@ commonality to use it? > + if (vma->vm_pgoff != 0) > + return -EINVAL; > + -> + if ((vma->vm_flags & VM_WRITE) = 0) +> + if ((vma->vm_flags & VM_WRITE) == 0) > + return -EPERM; > + > + pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + if (! -> + (vdata > + vmalloc(sizeof(struct vma_data) + pages * sizeof(long)))) +> + (vdata = +> + vmalloc(sizeof(struct vma_data) + pages * sizeof(long)))) > + return -ENOMEM; How about: @@ -99,3 +100,9 @@ if() condition? } -- Dave + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 9000a9f..312531c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\020051012194233.GG17458@lnx-holt.americas.sgi.com\0" "From\0Dave Hansen <haveblue@us.ibm.com>\0" "Subject\0Re: [Patch 2/2] Special Memory (mspec) driver.\0" - "Date\0Fri, 14 Oct 2005 05:12:05 +0000\0" + "Date\0Thu, 13 Oct 2005 22:12:05 -0700\0" "To\0Robin Holt <holt@sgi.com>\0" "Cc\0ia64 list <linux-ia64@vger.kernel.org>" linux-mm <linux-mm@kvack.org> @@ -66,12 +66,13 @@ "> +\tif (vma->vm_pgoff != 0)\n" "> +\t\treturn -EINVAL;\n" "> +\n" - "> +\tif ((vma->vm_flags & VM_WRITE) = 0)\n" + "> +\tif ((vma->vm_flags & VM_WRITE) == 0)\n" "> +\t\treturn -EPERM;\n" "> +\n" "> +\tpages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;\n" "> +\tif (!\n" - "> +\t (vdata > +\t vmalloc(sizeof(struct vma_data) + pages * sizeof(long))))\n" + "> +\t (vdata =\n" + "> +\t vmalloc(sizeof(struct vma_data) + pages * sizeof(long))))\n" "> +\t\treturn -ENOMEM;\n" "\n" "How about:\n" @@ -112,6 +113,12 @@ "\t\t...\n" "\t}\n" "\n" - -- Dave + "-- Dave\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -c7be92a35abb59c47d9a6b38de9ace6696b955b87e76d29432b045d71ce2a1e1 +3e7e06fb59cbb84d6c2d1249a03722b9c025708a83cb07e960881a1294c62dbf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.