From: James Bottomley <James.Bottomley@SteelEye.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jens Axboe <axboe@suse.de>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: Followup on patches as571 and as572
Date: Fri, 14 Oct 2005 12:31:13 -0500 [thread overview]
Message-ID: <1129311073.4824.21.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0510141239400.6253-100000@iolanthe.rowland.org>
On Fri, 2005-10-14 at 12:58 -0400, Alan Stern wrote:
> (b) The bizarre line that said
>
> error_sector &= ~(block_sectors - 1);
>
> is now gone. Do you know what that was intended to do?
It's not a bizzare line ... it's rounding down to our current set block
size. That was the difference I noticed in the reporting. The bio
layer maintains a separate sector size from the actual device, so if the
error occurs in the middle of a block sector (because block sectors >
hard sectors) then we report as though it occurred at the beginning of
the block sector.
James
next prev parent reply other threads:[~2005-10-14 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 15:09 Followup on patches as571 and as572 Alan Stern
2005-10-14 16:01 ` James Bottomley
2005-10-14 16:58 ` Alan Stern
2005-10-14 17:31 ` James Bottomley [this message]
2005-10-14 18:39 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129311073.4824.21.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.